Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All snapshots #520

Merged
merged 8 commits into from
Oct 30, 2024
Merged

All snapshots #520

merged 8 commits into from
Oct 30, 2024

Conversation

EmilHvitfeldt
Copy link
Member

All errors are now snapshotted whenever possible, otherwise they are labeled as unreachable

hfrick
hfrick approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🧹✨

tests/testthat/test-template.R Outdated Show resolved Hide resolved
@EmilHvitfeldt EmilHvitfeldt merged commit 8ab8903 into main Oct 30, 2024
11 checks passed
@EmilHvitfeldt EmilHvitfeldt deleted the all-snapshots branch October 30, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfrick hfrick hfrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilHvitfeldt @hfrick