Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cli_abort to R/misc.R #529

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Adds cli_abort to R/misc.R #529

merged 4 commits into from
Sep 12, 2024

Conversation

Dpananos
Copy link
Contributor

Closes #509

As with a few other of my PRs, the tests are going to fail because I've implemented pluralization.

For example, one of the calls to rlang::abort wrote `"class(es)" and so my tests fail since some of the tests trigger the singular cases. See below

── Failure (test-misc.R:176:3): get_rsplit() ───────────────────────────────────
Snapshot of code has changed:
    old                                                          | new                                                         
[2]   get_rsplit(warpbreaks, 1)                                  |   get_rsplit(warpbreaks, 1)                              [2]
[3] Condition                                                    | Condition                                                [3]
[4]   Error in `get_rsplit()`:                                   |   Error in `get_rsplit()`:                               [4]
[5]   ! No `get_rsplit()` method for this class(es) 'data.frame' -   ! No `get_rsplit()` method for this class 'data.frame' [5]

@hfrick hfrick merged commit 8ccee92 into tidymodels:main Sep 12, 2024
12 checks passed
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cli errors in R/misc.R
2 participants