Skip to content

Commit

Permalink
Release Candidate 1.0.9 (#1275)
Browse files Browse the repository at this point in the history
* temp remove parsnip dev dependency

* polish news

* update snapshot

* tmp remove remotes

* tmp change warn_new_levels()

* do revdepcheck

* Increment version number to 1.0.9
  • Loading branch information
EmilHvitfeldt authored Dec 14, 2023
1 parent 22cdc82 commit cc984ff
Show file tree
Hide file tree
Showing 11 changed files with 235 additions and 119 deletions.
6 changes: 2 additions & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: recipes
Title: Preprocessing and Feature Engineering Steps for Modeling
Version: 1.0.8.9000
Version: 1.0.9
Authors@R: c(
person("Max", "Kuhn", , "[email protected]", role = c("aut", "cre")),
person("Hadley", "Wickham", , "[email protected]", role = "aut"),
Expand Down Expand Up @@ -52,7 +52,7 @@ Suggests:
kernlab,
knitr,
modeldata (>= 0.1.1),
parsnip (>= 1.1.1.9001),
parsnip (>= 0.1.7),
RANN,
RcppRoll,
rmarkdown,
Expand All @@ -72,5 +72,3 @@ Config/testthat/edition: 3
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
Remotes:
tidymodels/parsnip
16 changes: 10 additions & 6 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,30 @@
# recipes (development version)
# recipes 1.0.9

* Minor speed-up and reduced memory consumption for `step_pca()` in the `bake()` stage by reducing unused multiplications (@jkennel, #1265)
## Improvements

* Fixed bug where `step_factor2string()` if `strings_as_factors = TRUE` is set in `prep()`. (#317)
* Minor speed-up and reduced memory consumption for `step_pca()` in the `bake()` stage by reducing unused multiplications (@jkennel, #1265)

* Document that `update_role()`, `add_role()` and `remove_role()` are applied before steps and checks. (#778)

* Documentation for tidy methods for all steps has been added when missing and improved to describe the return value more accurately. (#936)

* `step_dummy()` will now error if passed character instead of loudly ignoring them. Only applicable when setting `strings_as_factors = FALSE`. (#1233)

* Fixed bug where `tidy.step_cut()` always returned zero row tibbles for trained recipes. (#1229)

* It is now documented that `step_spline_b()` can be made periodic. (#1223)

* `prep()` now correctly throws a warning when `training` argument is set when prepping a prepped recipe, telling the user that it will be ignored. (#1244)

* When errors are thrown about wrongly typed input to steps, the offending variables and their types are now listed. (#1217)

* All warnings and errors have been updated to use the cli package for increased clarity and consistency. (#1237)

* Added warnings when `step_scale()`, `step_normalise()`, `step_center()` or `step_range()` result in `NaN` columns. (@mastoffel, #1221)

* All warnings and errors have been updated to use the cli package for increased clarity and consistency. (#1237)
## Bug Fixes

* Fixed bug where `step_factor2string()` if `strings_as_factors = TRUE` is set in `prep()`. (#317)

* Fixed bug where `tidy.step_cut()` always returned zero row tibbles for trained recipes. (#1229)

# recipes 1.0.8

Expand Down
2 changes: 1 addition & 1 deletion R/dummy.R
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ warn_new_levels <- function(dat, lvl, details = NULL) {
if (length(ind) > 0) {
lvl2 <- unique(dat[ind])
cli::cli_warn(c(
"!" = "There are new levels in a factor: {.var {lvl2}}.",
"!" = "There are new levels in a factor: {lvl2}",
details
))
}
Expand Down
3 changes: 1 addition & 2 deletions R/recipe.R
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,7 @@ inline_check <- function(x) {
found: {.and {.code {funs}}}.",
i = "Use steps to do transformations instead.",
i = "If your modeling engine uses special terms in formulas, pass \\
that formula to workflows as a \\
{.help [model formula](parsnip::model_formula)}."
that formula to workflows as a model formula."
))
}

Expand Down
66 changes: 36 additions & 30 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -1,33 +1,33 @@
# Platform

|field |value |
|:--------|:------------------------------------------------------------------------------------------|
|version |R version 4.3.0 (2023-04-21) |
|os |macOS Ventura 13.5 |
|system |aarch64, darwin20 |
|ui |RStudio |
|language |(EN) |
|collate |en_US.UTF-8 |
|ctype |en_US.UTF-8 |
|tz |America/Los_Angeles |
|date |2023-08-25 |
|rstudio |2023.09.0-daily+343 Desert Sunflower (desktop) |
|pandoc |3.1.1 @ /Applications/RStudio.app/Contents/Resources/app/quarto/bin/tools/ (via rmarkdown) |
|field |value |
|:--------|:-----------------------------------|
|version |R version 4.3.1 (2023-06-16) |
|os |macOS Sonoma 14.1.2 |
|system |aarch64, darwin20 |
|ui |RStudio |
|language |(EN) |
|collate |en_US.UTF-8 |
|ctype |en_US.UTF-8 |
|tz |America/Los_Angeles |
|date |2023-12-12 |
|rstudio |2023.12.0+359 Ocean Storm (desktop) |
|pandoc |2.17.1.1 @ /opt/homebrew/bin/pandoc |

# Dependencies

|package |old |new |Δ |
|:------------|:----------|:----------|:--|
|recipes |1.0.7 |1.0.7.9000 |* |
|cli |3.6.1 |3.6.1 | |
|recipes |1.0.8 |1.0.8.9000 |* |
|cli |3.6.2 |3.6.2 | |
|clock |0.7.0 |0.7.0 | |
|cpp11 |0.4.6 |0.4.6 | |
|data.table |1.14.8 |1.14.8 | |
|cpp11 |0.4.7 |0.4.7 | |
|data.table |1.14.10 |1.14.10 | |
|diagram |1.6.5 |1.6.5 | |
|digest |0.6.33 |0.6.33 | |
|dplyr |1.1.2 |1.1.2 | |
|dplyr |1.1.4 |1.1.4 | |
|ellipsis |0.3.2 |0.3.2 | |
|fansi |1.0.4 |1.0.4 | |
|fansi |1.0.6 |1.0.6 | |
|future |1.33.0 |1.33.0 | |
|future.apply |1.11.0 |1.11.0 | |
|generics |0.1.3 |0.1.3 | |
Expand All @@ -36,34 +36,34 @@
|gower |1.0.1 |1.0.1 | |
|hardhat |1.3.0 |1.3.0 | |
|ipred |0.9-14 |0.9-14 | |
|lava |1.7.2.1 |1.7.2.1 | |
|lifecycle |1.0.3 |1.0.3 | |
|lava |1.7.3 |1.7.3 | |
|lifecycle |1.0.4 |1.0.4 | |
|listenv |0.9.0 |0.9.0 | |
|lubridate |1.9.2 |1.9.2 | |
|lubridate |1.9.3 |1.9.3 | |
|magrittr |2.0.3 |2.0.3 | |
|numDeriv |2016.8-1.1 |2016.8-1.1 | |
|parallelly |1.36.0 |1.36.0 | |
|pillar |1.9.0 |1.9.0 | |
|pkgconfig |2.0.3 |2.0.3 | |
|prodlim |2023.03.31 |2023.03.31 | |
|prodlim |2023.08.28 |2023.08.28 | |
|progressr |0.14.0 |0.14.0 | |
|purrr |1.0.2 |1.0.2 | |
|R6 |2.5.1 |2.5.1 | |
|Rcpp |1.0.11 |1.0.11 | |
|rlang |1.1.1 |1.1.1 | |
|rlang |1.1.2 |1.1.2 | |
|shape |1.4.6 |1.4.6 | |
|SQUAREM |2021.1 |2021.1 | |
|stringi |1.7.12 |1.7.12 | |
|stringr |1.5.0 |1.5.0 | |
|stringi |1.8.3 |1.8.3 | |
|stringr |1.5.1 |1.5.1 | |
|tibble |3.2.1 |3.2.1 | |
|tidyr |1.3.0 |1.3.0 | |
|tidyselect |1.2.0 |1.2.0 | |
|timechange |0.2.0 |0.2.0 | |
|timeDate |4022.108 |4022.108 | |
|tzdb |0.4.0 |0.4.0 | |
|utf8 |1.2.3 |1.2.3 | |
|vctrs |0.6.3 |0.6.3 | |
|withr |2.5.0 |2.5.0 | |
|utf8 |1.2.4 |1.2.4 | |
|vctrs |0.6.5 |0.6.5 | |
|withr |2.5.2 |2.5.2 | |

# Revdeps

Expand All @@ -72,6 +72,12 @@
|package |version |error |warning |note |
|:------------|:-------|:-----|:-------|:----|
|D2MCS |1.0.1 |1 | | |
|dann |1.0.0 |1 | | |
|hydrorecipes |0.0.3 |1 | | |
|workboots |0.2.0 |1 | | |

## New problems (1)

|package |version |error |warning |note |
|:------------|:-------|:-----|:--------|:----|
|[healthcareai](problems.md#healthcareai)|2.5.1 |2 |1 __+1__ |1 |

12 changes: 9 additions & 3 deletions revdep/cran.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,20 @@
## revdepcheck results

We checked 63 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 69 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We saw 1 new problems
* We failed to check 3 packages

Issues with CRAN packages are summarised below.

### New problems
(This reports the first line of each new failure)

* healthcareai
checking dependencies in R code ... WARNING

### Failed to check

* D2MCS (NA)
* dann (NA)
* hydrorecipes (NA)
* workboots (NA)
134 changes: 74 additions & 60 deletions revdep/failures.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,80 @@ ERROR: lazy loading failed for package ‘D2MCS’
* removing ‘/Users/emilhvitfeldt/Github/recipes/revdep/checks.noindex/D2MCS/old/D2MCS.Rcheck/D2MCS’
```
# dann

<details>

* Version: 1.0.0
* GitHub: NA
* Source code: https://github.com/cran/dann
* Date/Publication: 2023-09-23 15:50:03 UTC
* Number of recursive dependencies: 121

Run `revdepcheck::revdep_details(, "dann")` for more info

</details>

## In both

* checking whether package ‘dann’ can be installed ... ERROR
```
Installation failed.
See ‘/Users/emilhvitfeldt/Github/recipes/revdep/checks.noindex/dann/new/dann.Rcheck/00install.out’ for details.
```

## Installation

### Devel

```
* installing *source* package ‘dann’ ...
** package ‘dann’ successfully unpacked and MD5 sums checked
** using staged installation
** libs
using C++ compiler: ‘Apple clang version 15.0.0 (clang-1500.0.40.1)’
using SDK: ‘MacOSX14.0.sdk’
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/include" -DNDEBUG -I'/Users/emilhvitfeldt/Github/recipes/revdep/library.noindex/recipes/new/Rcpp/include' -I'/Users/emilhvitfeldt/Github/recipes/revdep/library.noindex/dann/RcppArmadillo/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c RcppExports.cpp -o RcppExports.o
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/include" -DNDEBUG -I'/Users/emilhvitfeldt/Github/recipes/revdep/library.noindex/recipes/new/Rcpp/include' -I'/Users/emilhvitfeldt/Github/recipes/revdep/library.noindex/dann/RcppArmadillo/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c internal_armadillo_helpers.cpp -o internal_armadillo_helpers.o
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/include" -DNDEBUG -I'/Users/emilhvitfeldt/Github/recipes/revdep/library.noindex/recipes/new/Rcpp/include' -I'/Users/emilhvitfeldt/Github/recipes/revdep/library.noindex/dann/RcppArmadillo/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c internal_helpers_C.cpp -o internal_helpers_C.o
clang++ -arch arm64 -std=gnu++17 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/lib -L/opt/R/arm64/lib -o dann.so RcppExports.o internal_armadillo_helpers.o internal_helpers_C.o -L/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/lib -lRlapack -L/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/lib -lRblas -L/opt/gfortran/lib/gcc/aarch64-apple-darwin20.0/12.2.0 -L/opt/gfortran/lib -lgfortran -lemutls_w -lquadmath -F/Library/Frameworks/R.framework/Versions/4.3-arm64 -framework R -Wl,-framework -Wl,CoreFoundation
ld: warning: -single_module is obsolete
ld: warning: -multiply_defined is obsolete
ld: warning: search path '/opt/gfortran/lib/gcc/aarch64-apple-darwin20.0/12.2.0' not found
ld: warning: search path '/opt/gfortran/lib' not found
ld: library 'gfortran' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [dann.so] Error 1
ERROR: compilation failed for package ‘dann’
* removing ‘/Users/emilhvitfeldt/Github/recipes/revdep/checks.noindex/dann/new/dann.Rcheck/dann’
```
### CRAN

```
* installing *source* package ‘dann’ ...
** package ‘dann’ successfully unpacked and MD5 sums checked
** using staged installation
** libs
using C++ compiler: ‘Apple clang version 15.0.0 (clang-1500.0.40.1)’
using SDK: ‘MacOSX14.0.sdk’
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/include" -DNDEBUG -I'/Users/emilhvitfeldt/Github/recipes/revdep/library.noindex/recipes/old/Rcpp/include' -I'/Users/emilhvitfeldt/Github/recipes/revdep/library.noindex/dann/RcppArmadillo/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c RcppExports.cpp -o RcppExports.o
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/include" -DNDEBUG -I'/Users/emilhvitfeldt/Github/recipes/revdep/library.noindex/recipes/old/Rcpp/include' -I'/Users/emilhvitfeldt/Github/recipes/revdep/library.noindex/dann/RcppArmadillo/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c internal_armadillo_helpers.cpp -o internal_armadillo_helpers.o
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/include" -DNDEBUG -I'/Users/emilhvitfeldt/Github/recipes/revdep/library.noindex/recipes/old/Rcpp/include' -I'/Users/emilhvitfeldt/Github/recipes/revdep/library.noindex/dann/RcppArmadillo/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c internal_helpers_C.cpp -o internal_helpers_C.o
clang++ -arch arm64 -std=gnu++17 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/lib -L/opt/R/arm64/lib -o dann.so RcppExports.o internal_armadillo_helpers.o internal_helpers_C.o -L/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/lib -lRlapack -L/Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/lib -lRblas -L/opt/gfortran/lib/gcc/aarch64-apple-darwin20.0/12.2.0 -L/opt/gfortran/lib -lgfortran -lemutls_w -lquadmath -F/Library/Frameworks/R.framework/Versions/4.3-arm64 -framework R -Wl,-framework -Wl,CoreFoundation
ld: warning: -single_module is obsolete
ld: warning: -multiply_defined is obsolete
ld: warning: search path '/opt/gfortran/lib/gcc/aarch64-apple-darwin20.0/12.2.0' not found
ld: warning: search path '/opt/gfortran/lib' not found
ld: library 'gfortran' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [dann.so] Error 1
ERROR: compilation failed for package ‘dann’
* removing ‘/Users/emilhvitfeldt/Github/recipes/revdep/checks.noindex/dann/old/dann.Rcheck/dann’
```
# hydrorecipes

Expand Down Expand Up @@ -137,64 +211,4 @@ ERROR: compilation failed for package ‘hydrorecipes’
* removing ‘/Users/emilhvitfeldt/Github/recipes/revdep/checks.noindex/hydrorecipes/old/hydrorecipes.Rcheck/hydrorecipes’
```
# workboots

<details>

* Version: 0.2.0
* GitHub: https://github.com/markjrieke/workboots
* Source code: https://github.com/cran/workboots
* Date/Publication: 2022-05-16 06:40:02 UTC
* Number of recursive dependencies: 137

Run `revdepcheck::revdep_details(, "workboots")` for more info

</details>

## In both

* checking whether package ‘workboots’ can be installed ... ERROR
```
Installation failed.
See ‘/Users/emilhvitfeldt/Github/recipes/revdep/checks.noindex/workboots/new/workboots.Rcheck/00install.out’ for details.
```

## Installation

### Devel

```
* installing *source* package ‘workboots’ ...
** package ‘workboots’ successfully unpacked and MD5 sums checked
** using staged installation
** R
** inst
** byte-compile and prepare package for lazy loading
Error in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]) :
there is no package called ‘gridExtra’
Calls: <Anonymous> ... loadNamespace -> withRestarts -> withOneRestart -> doWithOneRestart
Execution halted
ERROR: lazy loading failed for package ‘workboots’
* removing ‘/Users/emilhvitfeldt/Github/recipes/revdep/checks.noindex/workboots/new/workboots.Rcheck/workboots’
```
### CRAN

```
* installing *source* package ‘workboots’ ...
** package ‘workboots’ successfully unpacked and MD5 sums checked
** using staged installation
** R
** inst
** byte-compile and prepare package for lazy loading
Error in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]) :
there is no package called ‘gridExtra’
Calls: <Anonymous> ... loadNamespace -> withRestarts -> withOneRestart -> doWithOneRestart
Execution halted
ERROR: lazy loading failed for package ‘workboots’
* removing ‘/Users/emilhvitfeldt/Github/recipes/revdep/checks.noindex/workboots/old/workboots.Rcheck/workboots’
```
Loading

0 comments on commit cc984ff

Please sign in to comment.