RC 1.0.2 (#1047)

* reknit readme * update news * update snapshots with new tidyselect version * update lifecycle snapshots * Increment version number to 1.0.2 * don't have examples on windows Co-authored-by: topepo <[email protected]>
tidymodels · Oct 16, 2022 · 79baabe · 79baabe
1 parent 4b631e6
commit 79baabe
Show file tree

Hide file tree

Showing 19 changed files with 45 additions and 37 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: recipes
 Title: Preprocessing and Feature Engineering Steps for Modeling
-Version: 1.0.1.9000
+Version: 1.0.2
 Authors@R: c(
     person("Max", "Kuhn", , "[email protected]", role = c("aut", "cre")),
     person("Hadley", "Wickham", , "[email protected]", role = "aut"),
@@ -27,7 +27,7 @@ Imports:
     gower,
     hardhat (>= 1.2.0),
     ipred (>= 0.9-12),
-    lifecycle,
+    lifecycle (>= 1.0.3),
     lubridate (>= 1.8.0),
     magrittr,
     Matrix,
@@ -36,7 +36,7 @@ Imports:
     stats,
     tibble,
     tidyr (>= 1.0.0),
-    tidyselect (>= 1.1.2),
+    tidyselect (>= 1.2.0),
     timeDate,
     utils,
     vctrs,

diff --git a/NEWS.md b/NEWS.md
@@ -1,18 +1,18 @@
-# recipes (development version)
+# recipes 1.0.2
 
 * A new set of basis functions were added: `step_spline_b()`, `step_spline_convex()`,  `step_spline_monotone()`, `step_spline_natural()`, `step_spline_nonnegative()`, and 
 `step_poly_bernstein()`.
 
-# recipes 1.0.1
-
-* Fixed bug where `step_holiday()` didn't work if it isn't have any missing values. (#1019)
-
 * `step_date()`, `step_dummy()`, `step_dummy_extract()`, `step_holiday()`, `step_ordinalscore()`, and `step_regex()` now returns integer results when appropriate. (#766)
 
 * The default for the `strict` argument in `step_integer()` has been changed from `FALSE` to `TRUE`. The function will thus return integers, rather than whole-number numerics, by default. (#766)
 
 * The default for the `value` argument in `step_intercept()` has been changed from `1` to `1L`. (#766)
 
+# recipes 1.0.1
+
+* Fixed bug where `step_holiday()` didn't work if it isn't have any missing values. (#1019)
+
 # recipes 1.0.0
 
 ## Improvements and Other Changes

diff --git a/R/nnmf_sparse.R b/R/nnmf_sparse.R
@@ -39,7 +39,7 @@
 #'
 #' @template case-weights-not-supported
 #'
-#' @examplesIf rlang::is_installed(c("modeldata", "RcppML", "ggplot2"))
+#' @examplesIf rlang::is_installed(c("modeldata", "RcppML", "ggplot2")) && .Platform$OS.type != "windows"
 #' library(Matrix)
 #' data(biomass, package = "modeldata")
 #'

diff --git a/README.md b/README.md
@@ -68,18 +68,18 @@ devtools::install_github("tidymodels/recipes")
 
 ## Contributing
 
--   For questions and discussions about tidymodels packages, modeling,
-    and machine learning, please [post on RStudio
-    Community](https://community.rstudio.com/c/ml/15).
+- For questions and discussions about tidymodels packages, modeling, and
+  machine learning, please [post on RStudio
+  Community](https://community.rstudio.com/c/ml/15).
 
--   If you think you have encountered a bug, please [submit an
-    issue](https://github.com/tidymodels/recipes/issues).
+- If you think you have encountered a bug, please [submit an
+  issue](https://github.com/tidymodels/recipes/issues).
 
--   Either way, learn how to create and share a
-    [reprex](https://reprex.tidyverse.org/articles/articles/learn-reprex.html)
-    (a minimal, reproducible example), to clearly communicate about your
-    code.
+- Either way, learn how to create and share a
+  [reprex](https://reprex.tidyverse.org/articles/articles/learn-reprex.html)
+  (a minimal, reproducible example), to clearly communicate about your
+  code.
 
--   Check out further details on [contributing guidelines for tidymodels
-    packages](https://www.tidymodels.org/contribute/) and [how to get
-    help](https://www.tidymodels.org/help/).
+- Check out further details on [contributing guidelines for tidymodels
+  packages](https://www.tidymodels.org/contribute/) and [how to get
+  help](https://www.tidymodels.org/help/).
diff --git a/tests/testthat/_snaps/R4.2/selections.md b/tests/testthat/_snaps/R4.2/selections.md
@@ -3,6 +3,8 @@
     Code
       recipes_eval_select(quos = quos(I(beds:sqft)), data = Sacramento, info = info1)
     Condition
-      Error in `unique.default()`:
+      Error in `recipes_eval_select()`:
+      ! Problem while evaluating `I(beds:sqft)`.
+      Caused by error in `unique.default()`:
       ! object 'beds' not found
 
diff --git a/tests/testthat/_snaps/dummies.md b/tests/testthat/_snaps/dummies.md
@@ -100,7 +100,7 @@
     Condition
       Error:
       ! The `preserve` argument of `step_dummy()` was deprecated in recipes 0.1.16 and is now defunct.
-      Please use the `keep_original_cols` argument instead.
+      i Please use the `keep_original_cols` argument instead.
 
 # printing
 

diff --git a/tests/testthat/_snaps/impute_bag.md b/tests/testthat/_snaps/impute_bag.md
@@ -5,7 +5,7 @@
     Condition
       Error:
       ! `step_bagimpute()` was deprecated in recipes 0.1.16 and is now defunct.
-      Please use `step_impute_bag()` instead.
+      i Please use `step_impute_bag()` instead.
 
 # printing
 

diff --git a/tests/testthat/_snaps/impute_knn.md b/tests/testthat/_snaps/impute_knn.md
@@ -5,7 +5,7 @@
     Condition
       Error:
       ! `step_knnimpute()` was deprecated in recipes 0.1.16 and is now defunct.
-      Please use `step_impute_knn()` instead.
+      i Please use `step_impute_knn()` instead.
 
 # printing
 

diff --git a/tests/testthat/_snaps/impute_lower.md b/tests/testthat/_snaps/impute_lower.md
@@ -13,7 +13,7 @@
     Condition
       Error:
       ! `step_lowerimpute()` was deprecated in recipes 0.1.16 and is now defunct.
-      Please use `step_impute_lower()` instead.
+      i Please use `step_impute_lower()` instead.
 
 # printing
 

diff --git a/tests/testthat/_snaps/impute_mean.md b/tests/testthat/_snaps/impute_mean.md
@@ -13,7 +13,7 @@
     Condition
       Error:
       ! `step_meanimpute()` was deprecated in recipes 0.1.16 and is now defunct.
-      Please use `step_impute_mean()` instead.
+      i Please use `step_impute_mean()` instead.
 
 # printing
 

diff --git a/tests/testthat/_snaps/impute_median.md b/tests/testthat/_snaps/impute_median.md
@@ -13,7 +13,7 @@
     Condition
       Error:
       ! `step_medianimpute()` was deprecated in recipes 0.1.16 and is now defunct.
-      Please use `step_impute_median()` instead.
+      i Please use `step_impute_median()` instead.
 
 # printing
 

diff --git a/tests/testthat/_snaps/impute_mode.md b/tests/testthat/_snaps/impute_mode.md
@@ -22,7 +22,7 @@
     Condition
       Error:
       ! `step_modeimpute()` was deprecated in recipes 0.1.16 and is now defunct.
-      Please use `step_impute_mode()` instead.
+      i Please use `step_impute_mode()` instead.
 
 # printing
 

diff --git a/tests/testthat/_snaps/impute_roll.md b/tests/testthat/_snaps/impute_roll.md
@@ -32,7 +32,7 @@
     Condition
       Error:
       ! `step_rollimpute()` was deprecated in recipes 0.1.16 and is now defunct.
-      Please use `step_impute_roll()` instead.
+      i Please use `step_impute_roll()` instead.
 
 # printing
 

diff --git a/tests/testthat/_snaps/nzv.md b/tests/testthat/_snaps/nzv.md
@@ -1,7 +1,7 @@
 # altered freq_cut and unique_cut
 
     The `options` argument of `step_nzv()` was deprecated in recipes 0.1.7 and is now defunct.
-    Please use the arguments `freq_cut` and `unique_cut` instead.
+    i Please use the arguments `freq_cut` and `unique_cut` instead.
 
 # Deprecation warning
 
@@ -11,7 +11,7 @@
     Condition
       Error:
       ! The `options` argument of `step_nzv()` was deprecated in recipes 0.1.7 and is now defunct.
-      Please use the arguments `freq_cut` and `unique_cut` instead.
+      i Please use the arguments `freq_cut` and `unique_cut` instead.
 
 # printing
 

diff --git a/tests/testthat/_snaps/pls_new.md b/tests/testthat/_snaps/pls_new.md
@@ -21,7 +21,7 @@
     Condition
       Error:
       ! The `preserve` argument of `step_pls()` was deprecated in recipes 0.1.16 and is now defunct.
-      Please use the `keep_original_cols` argument instead.
+      i Please use the `keep_original_cols` argument instead.
 
 # print method
 

diff --git a/tests/testthat/_snaps/rm.md b/tests/testthat/_snaps/rm.md
@@ -11,7 +11,9 @@
     Code
       prep(rec_1, training = iris %>% slice(1:75))
     Condition
-      Error in `all_of()`:
+      Error in `recipes_eval_select()`:
+      ! Problem while evaluating `all_of(sepal_vars)`.
+      Caused by error in `as_indices_impl()`:
       ! object 'sepal_vars' not found
 
 # printing

diff --git a/tests/testthat/_snaps/select.md b/tests/testthat/_snaps/select.md
@@ -3,7 +3,9 @@
     Code
       prep(rec_1, training = iris_train)
     Condition
-      Error in `all_of()`:
+      Error in `recipes_eval_select()`:
+      ! Problem while evaluating `all_of(sepal_vars)`.
+      Caused by error in `as_indices_impl()`:
       ! object 'sepal_vars' not found
 
 # printing

diff --git a/tests/testthat/_snaps/selections.md b/tests/testthat/_snaps/selections.md
@@ -3,7 +3,9 @@
     Code
       recipes_eval_select(quos = quos(log(beds)), data = Sacramento, info = info1)
     Condition
-      Error:
+      Error in `recipes_eval_select()`:
+      ! Problem while evaluating `log(beds)`.
+      Caused by error:
       ! object 'beds' not found
 
 ---

diff --git a/tests/testthat/_snaps/terms-select.md b/tests/testthat/_snaps/terms-select.md
@@ -5,7 +5,7 @@
     Condition
       Warning:
       `terms_select()` was deprecated in recipes 0.1.17.
-      Please use `recipes_eval_select()` instead.
+      i Please use `recipes_eval_select()` instead.
     Output
       [1] "city"      "zip"       "beds"      "baths"     "sqft"      "type"     
       [7] "price"     "latitude"  "longitude"