Missing snapshots

[hfrick]

library(tidyverse)

# https://github.com/r-lib/covr/issues/482
res_tbl <- devtools::test_coverage() |>
  purrr::map(~tibble(
    value = if_else(is.null(.x$value), NA, .x$value), 
    code = as.character(.x$srcref)
  )) |>
  purrr::list_rbind(names_to = "file")

res_tbl |>
  filter(value == 0, str_detect(code, "(cli_abort|cli_warn|cli_inform|abort|warn)")) |>
  arrange(file) |>
  mutate(file = str_extract(file, ".*?:.*?:")) |>
  mutate(file = str_remove(file, ":$")) |>
  pull(file) |>
  cat(sep = "\n")

gives

use.R:130
use.R:134
util.R:17

but the two in use.R are tested in

hardhat/tests/testthat/test-use.R

Lines 64 to 68 in 92ad391

	test_that("`model` can only be a single string", {
	expect_snapshot(error = TRUE, create_modeling_package(path = "my/path", model = c("model1", "model2")))
	expect_snapshot(error = TRUE, create_modeling_package(path = "my/path", model = 1))
	expect_snapshot(error = TRUE, create_modeling_package(path = "my/path", model = "model with space"))
	})

and for the one in util.R I opened #267

[topepo]

contr_one_hot() is also in parsnip (where it is exported).

There are tests there that are a bit more extensive: https://github.com/tidymodels/parsnip/blob/main/tests/testthat/test-contr_one_hot.R

You can bring those over here and I'll open a parsnip issue about the duplication. hardhat would have to export this function for parsnip to use it.

[topepo]

tidymodels/parsnip#1215

[hfrick]

Ah, good find!! I've opened #271 as a companion to the parsnip issue