Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from rlang::abort() in aaa_ranges.R, aaa_unknown.R, encode_unit.R, and finalize.R #352

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

EmilHvitfeldt
Copy link
Member

Ref: #311

This PR switches from rlang::abort() in aaa_ranges.R, aaa_unknown.R, encode_unit.R, and finalize.R

Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️

R/encode_unit.R Outdated Show resolved Hide resolved
cli::cli_abort(
c(
x = "{.arg range} must have two values: an upper and lower bound.",
i = "{length(range)} value{?s} {?was/were} provided.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@hfrick hfrick merged commit d4fbf44 into main Sep 20, 2024
11 checks passed
@hfrick hfrick deleted the cli-abort-second-half branch September 20, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants