Expand space-filling designs #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfrick
reviewed
Apr 15, 2024
There was a problem hiding this comment.
I like one function for space-filling designs better than 6 different ones 👍
With that we have a mismatch in what's available/exported between different types of space-filling designs though: we have grid_latin_hypercube() and grid_max_entropy() but no, say, grid_audze_eglais().
I'm in favor of deprecating grid_latin_hypercube() and grid_max_entropy(), starting with a soft-deprecation. This can and should be a separate issue and PR but we should agree on what to do with that mismatch before adding grid_space_filling().
topepo
commented
Apr 18, 2024
|
The failure on R 3.6 is okay, we don't support that version anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #307
The space-filling design functionality was expanded to include several new types of designs: Audze-Eglais, max/min L1, max/min L2, and uniform. These are all pre-computed designs accessed from the sfd package.
A new function is used to access all of the space-filling designs called
grid_space_filling().