Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support building for macos #1130

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

ewanharris
Copy link
Collaborator

Marking draft as this is a WIP, would like to test debugging and other items first but am struggling to be able to build to macOS on my machine 🤷🏻

Closes #1129

@hansemannn
Copy link
Contributor

@ewanharris I would actually take this for a base implementation already and then we could still iterate on it later. Would that be okay?

@ewanharris
Copy link
Collaborator Author

@hansemannn that sounds good to me, lemme check it out again later and get it merged

@ewanharris ewanharris marked this pull request as ready for review August 19, 2023 20:10
@ewanharris ewanharris merged commit 5a269a8 into tidev:master Aug 19, 2023
6 checks passed
@ewanharris ewanharris deleted the feat/macos-support branch August 19, 2023 20:35
@ewanharris
Copy link
Collaborator Author

@hansemannn are you looking to use this? Want a release putting out?

@hansemannn
Copy link
Contributor

I don't need it personally, but thought some users that have macOS apps could benefit from it :)

github-actions bot pushed a commit that referenced this pull request Aug 20, 2023
# [1.2.0](v1.1.0...v1.2.0) (2023-08-20)

### Bug Fixes

* more de strings ([#1159](#1159)) ([4aace01](4aace01))
* **providers:** always generate completion data after info load ([#1171](#1171)) ([4688458](4688458)), closes [#1165](#1165)

### Features

* **explorer/build:** allow building modules to specific targets ([#1000](#1000)) ([4af0313](4af0313))
* support building for macos ([#1130](#1130)) ([5a269a8](5a269a8)), closes [#1129](#1129)
* support German language ([#1148](#1148)) ([42da08d](42da08d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding build options for macos, macos-adhoc, MacAppStore
2 participants