Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android)(9_3_X): update v8 to 8.4.371.22 #11849

Merged
merged 20 commits into from
Aug 17, 2020

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jul 28, 2020

TEST CASE #1
const window = Ti.UI.createWindow({ backgroundColor: 'white' });
const label = Ti.UI.createLabel({ color: 'black' });

try {
	if (!WebAssembly) {
		throw Error('WebAssembly not supported.');
	}

	// Engine supports WebAssembly, attempt to run a module export.
	const WASM_BUFFER = new Uint8Array([0,97,115,109,1,0,0,0,1,133,128,128,128,0,1,96,0,1,127,3,130,128,128,128,0,1,0,4,132,128,128,128,0,1,112,0,0,5,131,128,128,128,0,1,0,1,6,129,128,128,128,0,0,7,145,128,128,128,0,2,6,109,101,109,111,114,121,2,0,4,109,97,105,110,0,0,10,138,128,128,128,0,1,132,128,128,128,0,0,65,42,11]);
	const WASM_MODULE = new WebAssembly.Module(WASM_BUFFER);

	const instance = new WebAssembly.Instance(WASM_MODULE).exports;
	label.text = instance.main();
} catch (e) {
	label.color = 'red';
	label.text = e.message;
}

window.add(label);
window.open();
  • Window should display 42.
TEST CASE #2
const window = Ti.UI.createWindow();
const file = Ti.Filesystem.getFile('test');

window.addEventListener('open', _ => {
	console.log(`window: ${window.toString()}`);
	console.log(`file: ${file.toString()}`);
});

window.open();
window: [object Window]
file: [object TiFileProxy]

TIMOB-27887
TIMOB-27970

@build
Copy link
Contributor

build commented Jul 28, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 4 tests have failed There are 4 tests failing and 719 skipped out of 8081 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.Media.AudioPlayer#start, #stop (14.0)25.012
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/8397E161-2778-43CE-AB1B-BDA17BDD4023/data/Containers/Bundle/Application/827DEFE4-FF96-497B-899B-E350CC10E8D0/mocha.app/ti-mocha.js:4326:27
ios.ipad.Titanium.UI.WebViewprogress event (14.0)10.002
Error: timeout of 10000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/8397E161-2778-43CE-AB1B-BDA17BDD4023/data/Containers/Bundle/Application/827DEFE4-FF96-497B-899B-E350CC10E8D0/mocha.app/ti-mocha.js:4290:32
ios.ipad.Titanium.UI.WebViewhtml-script-tag (14.0)10.001
Error: timeout of 10000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/8397E161-2778-43CE-AB1B-BDA17BDD4023/data/Containers/Bundle/Application/827DEFE4-FF96-497B-899B-E350CC10E8D0/mocha.app/ti-mocha.js:4290:32
ios.ipad.Titanium.UI.WebView.zoomLevel (14.0)10.002
Error: timeout of 10000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/8397E161-2778-43CE-AB1B-BDA17BDD4023/data/Containers/Bundle/Application/827DEFE4-FF96-497B-899B-E350CC10E8D0/mocha.app/ti-mocha.js:4290:32

Generated by 🚫 dangerJS against af67827

@tidev tidev deleted a comment from build Jul 28, 2020
@tidev tidev deleted a comment from build Jul 28, 2020
@tidev tidev deleted a comment from build Jul 28, 2020
@sgtcoolguy

This comment has been minimized.

@garymathews garymathews changed the title chore(android): update v8 to 8.4.371.22 chore(android)(9_3_X): update v8 to 8.4.371.22 Aug 4, 2020
android/titanium/V8Snapshots.h.ejs Outdated Show resolved Hide resolved
android/titanium/libv8-services.js Outdated Show resolved Hide resolved
android/titanium/libv8-services.js Outdated Show resolved Hide resolved
android/titanium/libv8-services.js Outdated Show resolved Hide resolved
{
return "[object Window]";
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? I just tested calling toString() on a Ti.UI.Window instance on 9.1.0 and it returned "[object Window]".

On iOS, it returns "[object TiUIWindow]" which is the name of the objective-c class. That's an interesting inconsistency.

Copy link
Contributor Author

@garymathews garymathews Aug 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this test failed with this PR: ti.ui.window.test.js#L377
I realized we didn't override toString() on our KrollProxy, so I added that here

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garymathews
Copy link
Contributor Author

@jquick-axway @sgtcoolguy could we merge this? The tests validate everything manual testing would.

@jquick-axway
Copy link
Contributor

Yes, let's go ahead and merge this.

@sgtcoolguy sgtcoolguy merged commit 0f3ef66 into tidev:9_3_X Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants