-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android)(9_3_X): update v8 to 8.4.371.22 #11849
Conversation
Tests:
|
This comment has been minimized.
This comment has been minimized.
{ | ||
return "[object Window]"; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? I just tested calling toString()
on a Ti.UI.Window
instance on 9.1.0 and it returned "[object Window]"
.
On iOS, it returns "[object TiUIWindow]"
which is the name of the objective-c class. That's an interesting inconsistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason this test failed with this PR: ti.ui.window.test.js#L377
I realized we didn't override toString()
on our KrollProxy, so I added that here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jquick-axway @sgtcoolguy could we merge this? The tests validate everything manual testing would. |
Yes, let's go ahead and merge this. |
8.4.371.22
Proxy.toString()
to be overridden, which seems to have been the intended behaviourTEST CASE #1
42
.TEST CASE #2
TIMOB-27887
TIMOB-27970