Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Playwright #1643

Closed
wants to merge 7 commits into from
Closed

feature: Playwright #1643

wants to merge 7 commits into from

Conversation

vojtech-cerveny
Copy link
Contributor

  • basic flow how we can use playwright for basic tests of UI

  • small changes (tweaks) of Login.js and how Electron handle externalUrl.

  • Now I can call function handleIncomingUrl and return correct url (like tidepooluploader://localhost/keycloak-redirect#state....

        await window.evaluate((url) => {
          window.electron.handleIncomingUrl(url);
        }, href);

How to test:
Add these variables (qa2 personal account) into .env

E2E_USER_EMAIL=
E2E_USER_PASSWORD=
  • yarn test:e2e --headed for visible Chrome
  • yarn test:e2e

It is draft, please let me know what do you think about my changes.

@krystophv
Copy link
Member

Would it be possible to do this work against the in-browser-merged branch? There are a lot of changes in that branch that will have conflicts with these changes if we were to merge into master, I'm pretty sure.

@vojtech-cerveny
Copy link
Contributor Author

#1644 - new version pointed to in-browser-merged branch as it as requested.

@vojtech-cerveny vojtech-cerveny deleted the playwright branch July 18, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants