-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-3272,WEB-3273] Clinician-initiated patient data connection management #1485
Open
clintonium-119
wants to merge
53
commits into
develop
Choose a base branch
from
WEB-3272-patient-data-linking-after-creation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WEB-3272,WEB-3273] Clinician-initiated patient data connection management #1485
clintonium-119
wants to merge
53
commits into
develop
from
WEB-3272-patient-data-linking-after-creation
+4,275
−1,082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…point with new generic one
… allow reuse in various contexts
…open prop for visibility
….com:tidepool-org/blip into WEB-3272-patient-data-linking-after-creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB-3272 WEB-3273
These PRs basically create new data source components and dialogs for allowing multiple data sources to be managed.
There are a few methods exported from
DataConnections.js
to allow me to more easily prototype in Storybook and test all of the various possible connection states (and their respective UI, messaging and button handling).It's the most complex aspect of the PR, and I apologize for any headaches it may cause in getting your head around how it works. It does allow the
DataConnection
component itself to be "dumb" and reusable for all providers and connection states, for both clinic patients, and logged-in users (to be implemented in the next PR).As far as major UX flow changes, essentially, the dexcom connection requests and statuses have been removed from the patient add/edit forms, and moved to a modal that can either be shown as a subsequent step after adding/editing a patient, as well as opened directly from the patient "more" menus on the patient lists and Tide dashboard.
These various components will also be accessible in the near future from banners on the patient data view, the 'no data' new user startup, and the devices settings page (which will be the new home for patient data management, which currently lives on the patient profile page)
Sorry for the long write-up - just wanted to provide some insight for why I organized things the way I did. Felt a bit different than my normal patterns, but seemed necessary given the extensive use these will get across our UI in various ways.
Last changes to call out are small changes to our api => redux state flow due to the clinic patient backend model where
patient.lastRequestedDexcomConnectTime
is replaced by a new genericpatient.connectionRequests
array.Related PRs:
tidepool-org/viz#429
tidepool-org/platform-client#182