Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3272,WEB-3273] Clinician-initiated patient data connection management #1485

Open
wants to merge 53 commits into
base: develop
Choose a base branch
from

Conversation

clintonium-119
Copy link
Member

@clintonium-119 clintonium-119 commented Dec 10, 2024

WEB-3272 WEB-3273

These PRs basically create new data source components and dialogs for allowing multiple data sources to be managed.
There are a few methods exported from DataConnections.js to allow me to more easily prototype in Storybook and test all of the various possible connection states (and their respective UI, messaging and button handling).

It's the most complex aspect of the PR, and I apologize for any headaches it may cause in getting your head around how it works. It does allow the DataConnection component itself to be "dumb" and reusable for all providers and connection states, for both clinic patients, and logged-in users (to be implemented in the next PR).

As far as major UX flow changes, essentially, the dexcom connection requests and statuses have been removed from the patient add/edit forms, and moved to a modal that can either be shown as a subsequent step after adding/editing a patient, as well as opened directly from the patient "more" menus on the patient lists and Tide dashboard.

These various components will also be accessible in the near future from banners on the patient data view, the 'no data' new user startup, and the devices settings page (which will be the new home for patient data management, which currently lives on the patient profile page)

Sorry for the long write-up - just wanted to provide some insight for why I organized things the way I did. Felt a bit different than my normal patterns, but seemed necessary given the extensive use these will get across our UI in various ways.

Last changes to call out are small changes to our api => redux state flow due to the clinic patient backend model where patient.lastRequestedDexcomConnectTime is replaced by a new generic patient.connectionRequests array.

Related PRs:

tidepool-org/viz#429
tidepool-org/platform-client#182

@clintonium-119 clintonium-119 marked this pull request as ready for review January 8, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant