-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACK-2540] Reports api #77
Open
jh-bate
wants to merge
21
commits into
master
Choose a base branch
from
reports-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+214
−44
Open
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ccc3b97
export report endpoint wip
jh-bate c2d6c45
wip v2
jh-bate 3e3caa3
initial report(s) request schema
jh-bate 59dddf7
Merge branch 'master' into reports-api
jh-bate 6a844c4
formatting and resp error examples
jh-bate 9d0814b
common used of units
jh-bate 9d4a9f8
rename for case
jh-bate c987df1
fix params glucoseunits reference
jh-bate 02a0b27
Merge branch 'master' into reports-api
jh-bate c0a4b2f
add defaults and required vals
jh-bate ff09cdf
use timezonename ref
jh-bate 5ad5d85
Merge branch 'master' into reports-api
jh-bate 989bc82
updates for pdf report api
jh-bate 9ac6811
remove report request for now
jh-bate e3e3f06
add dob and fullname
jh-bate cce5e8e
formatting
jh-bate 64f43f7
include post endpoint for reports
jh-bate ea5ca00
fix defaults
jh-bate 8c5b253
fix reference
jh-bate cafb99b
remove unused model
jh-bate 84555a7
revert mrn ref for patient model
jh-bate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
title: Date Range | ||
description: >- | ||
start and end datetime | ||
type: object | ||
properties: | ||
startDate: | ||
$ref: './datetime.v1.yaml' | ||
endDate: | ||
$ref: './datetime.v1.yaml' | ||
required: | ||
- startDate | ||
- endDate |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,6 @@ content: | |
'application/json': | ||
schema: | ||
$ref: '../models/error.v1.yaml' | ||
example: | ||
code: 400 | ||
message: 'Bad request' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,6 @@ content: | |
'application/json': | ||
schema: | ||
$ref: '../models/error.v1.yaml' | ||
example: | ||
code: 403 | ||
message: 'Forbidden' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,8 @@ | ||
description: 204 No Content | ||
content: | ||
'application/json': | ||
schema: | ||
$ref: '../models/error.v1.yaml' | ||
example: | ||
code: 204 | ||
message: 'No Content' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,6 @@ content: | |
'application/json': | ||
schema: | ||
$ref: '../models/error.v1.yaml' | ||
example: | ||
code: 404 | ||
message: 'Not Found' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,6 @@ content: | |
'application/json': | ||
schema: | ||
$ref: '../models/error.v1.yaml' | ||
example: | ||
code: 500 | ||
message: 'Server Error' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,6 @@ content: | |
'application/json': | ||
schema: | ||
$ref: '../models/error.v1.yaml' | ||
example: | ||
code: 401 | ||
message: 'Unauthorized' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
title: Report details | ||
description: >- | ||
Report details | ||
type: object | ||
properties: | ||
reports: | ||
$ref: ./reporttype.v1.yaml | ||
default: | ||
- all | ||
tzName: | ||
$ref: ../../data/models/timezonename.v1.yaml | ||
default: UTC | ||
bgUnits: | ||
$ref: ../../data/models/blood/units.v1.yaml | ||
default: mmol/L | ||
startDate: | ||
$ref: ../../common/models/datetime.v1.yaml | ||
endDate: | ||
$ref: ../../common/models/datetime.v1.yaml | ||
example: | ||
reports: | ||
- daily | ||
- basics | ||
- settings | ||
tzName: 'NZ' | ||
bgUnits: mmol/L | ||
startDate: '2022-02-06T02:37:46Z' | ||
endDate: '2022-03-06T02:37:46Z' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
title: New Report | ||
description: >- | ||
User report | ||
type: object | ||
required: [userDetails] | ||
properties: | ||
reportDetails: | ||
$ref: ./reportdetail.v1.yaml | ||
userDetails: | ||
$ref: ./reportuser.v1.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
title: Reports type | ||
type: array | ||
minItems: 1 | ||
maxItems: 5 | ||
items: | ||
type: string | ||
enum: | ||
- daily | ||
- bgLog | ||
- basics | ||
- agp | ||
- settings | ||
- all |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
title: Report user | ||
description: >- | ||
Report user | ||
type: object | ||
required: [fullName, mrn, dob] | ||
properties: | ||
fullName: | ||
$ref: ../../metadata/models/fullname.v1.yaml | ||
mrn: | ||
$ref: ../../metadata/models/mrn.v1.yaml | ||
dob: | ||
$ref: ../../common/models/birthday.v1.yaml | ||
example: | ||
fullName: User Name' | ||
mrn: 'mrn123' | ||
dob: '1999-04-01' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
description: >- | ||
Date of birth | ||
name: dob | ||
in: query | ||
schema: | ||
$ref: '../../common/models/birthday.v1.yaml' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
description: >- | ||
Full name | ||
name: fullName | ||
in: query | ||
schema: | ||
$ref: '../../metadata/models/fullname.v1.yaml' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
description: >- | ||
Glucose units of the exported data | ||
Glucose units | ||
name: bgUnits | ||
in: query | ||
schema: | ||
$ref: '../models/glucoseunits.v1.yaml' | ||
$ref: '../../data/models/blood/units.v1.yaml' | ||
default: mmol/L |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
description: >- | ||
Report Type. The type of report(s) to produce. | ||
It can be a single value like `/export/report/userid?reports=apg` or a comma separated list like `/export/report/userid?reports=agp,daily,basics`. | ||
name: reports | ||
in: query | ||
required: false | ||
style: form | ||
explode: false | ||
schema: | ||
$ref: '../models/reporttype.v1.yaml' | ||
default: all |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
description: >- | ||
Timezone name | ||
name: tzName | ||
in: query | ||
required: false | ||
schema: | ||
$ref: ../../data/models/timezonename.v1.yaml | ||
default: UTC |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making changes to clinic service models is undesirable, because the clinic and server stubs are generated from this spec. I have previously found the deep references are not well supported by the code generator and cause issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all done @toddkazakov - I have removed that update