Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecraft Server app: Removes old caching, vertical center image, logic for validating fields #1909

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

p0ns
Copy link
Contributor

@p0ns p0ns commented Oct 1, 2023

Description

Fixes minecraft app

  • Removes old caching
  • vertical center image
  • logic for validating fields
  • default image

Copilot

🤖 Generated by Copilot at 688b64b

Summary

🌐🐛🎨

Improved the performance, reliability, and appearance of the minecraft_server.star app. Added HTTP cache to reduce network requests, added error handling for JSON parsing, and centered the text and icons on the display.

minecraft_server.star is the key to our fate
We refactored the code to make it great
We use the HTTP cache to speed up the load
We handle JSON errors and center the mode

Walkthrough

  • Simplify and improve main function using HTTP cache feature, error handling, and render.Box (link)
  • Remove unused imports of cache.star and json.star modules (link)

@p0ns p0ns requested a review from matslina as a code owner October 1, 2023 07:29
@tidbyt
Copy link

tidbyt bot commented Oct 1, 2023

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
🟡 Original Author The original author (Cast324) does not match the PR author (p0ns)

Previews

apps/minecraftserver/minecraft_server.star:

@tidbyt-bot
Copy link

tidbyt-bot commented Oct 1, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@p0ns p0ns force-pushed the minecraft-fixes branch 2 times, most recently from 93f22f6 to be56c84 Compare October 1, 2023 07:31
@p0ns
Copy link
Contributor Author

p0ns commented Oct 1, 2023

I have read the CLA Document and I hereby sign the CLA

@p0ns p0ns force-pushed the minecraft-fixes branch from be56c84 to 688b64b Compare October 1, 2023 07:36
matslina
matslina previously approved these changes Oct 2, 2023
apps/minecraftserver/minecraft_server.star Outdated Show resolved Hide resolved
@matslina
Copy link
Contributor

matslina commented Oct 2, 2023

@Cast324 FYI

@p0ns p0ns force-pushed the minecraft-fixes branch from b1bc3a4 to dbee631 Compare October 3, 2023 04:04
@p0ns
Copy link
Contributor Author

p0ns commented Oct 3, 2023

Added TTL and rebased :)

@p0ns p0ns requested a review from matslina October 3, 2023 04:05
@p0ns
Copy link
Contributor Author

p0ns commented Oct 11, 2023

I was wondering if there's anything else needed to merge this. Thanks!

@matslina matslina merged commit 541dcb2 into tidbyt:main Oct 12, 2023
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants