Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ignite sdks #80

Merged
merged 1 commit into from
Dec 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions android/build.gradle
Original file line number Diff line number Diff line change
@@ -93,14 +93,14 @@ dependencies {
//noinspection GradleDynamicVersion
implementation "com.facebook.react:react-native:+"
implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
implementation 'androidx.compose.material:material:1.4.3'
implementation 'androidx.compose.material:material:1.7.4'
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4'
implementation 'com.google.code.gson:gson:2.10.1'

implementation 'com.ticketmaster.accounts:authentication:3.9.0'
implementation 'com.ticketmaster.tickets:tickets:3.9.1'
implementation 'com.ticketmaster.tickets:secure-entry:1.2.10'
implementation 'com.ticketmaster.accounts:authentication:3.10.0'
implementation 'com.ticketmaster.tickets:tickets:3.10.0'
implementation 'com.ticketmaster.tickets:secure-entry:1.3.0'
implementation 'com.ticketmaster.retail:purchase:3.2.0'
implementation 'com.ticketmaster.retail:prepurchase:3.2.0'
implementation 'com.ticketmaster.retail:discoveryapi:3.2.0'
1 change: 0 additions & 1 deletion example/android/app/build.gradle
Original file line number Diff line number Diff line change
@@ -119,7 +119,6 @@ android {
dependencies {
implementation 'androidx.appcompat:appcompat:1.4.1'
implementation 'androidx.constraintlayout:constraintlayout:2.1.3'
implementation 'androidx.compose.material:material:1.4.3'

implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlinVersion"
// The version of react-native is set by the React Native Gradle Plugin
2 changes: 1 addition & 1 deletion react-native-ticketmaster-ignite.podspec
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ Pod::Spec.new do |s|

# Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
# See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
s.dependency "TM-Ignite", '= 1.11.2'
s.dependency "TM-Ignite", '= 1.11.3'
if respond_to?(:install_modules_dependencies, true)
install_modules_dependencies(s)
else

Unchanged files with check annotations Beta

component={Home}
options={{
tabBarLabel: 'Home',
tabBarIcon: ({ focused }) => (

Check warning on line 44 in example/src/navigators/BottomTabs.tsx

GitHub Actions / lint

Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “BottomTabs” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true
<HomeIcon fill={focused ? Config.PRIMARY_COLOR : 'grey'} />
),
}}
headerShadowVisible: false,
tabBarLabel: 'Tickets SDK (Embedded)',
unmountOnBlur: true,
tabBarIcon: ({ focused }) => (

Check warning on line 56 in example/src/navigators/BottomTabs.tsx

GitHub Actions / lint

Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “BottomTabs” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true
<MyEventsIcon fill={focused ? Config.PRIMARY_COLOR : 'grey'} />
),
}}
headerShadowVisible: false,
tabBarLabel: 'Secure Entry',
unmountOnBlur: true,
tabBarIcon: ({ focused }) => (

Check warning on line 68 in example/src/navigators/BottomTabs.tsx

GitHub Actions / lint

Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “BottomTabs” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true
<MyEventsIcon fill={focused ? Config.PRIMARY_COLOR : 'grey'} />
),
}}
import { TicketsSdkEmbedded } from 'react-native-ticketmaster-ignite';
const MyEvents = () => {
return <TicketsSdkEmbedded style={{ height: '95%' }} />;

Check warning on line 5 in example/src/screens/MyEvents.tsx

GitHub Actions / lint

Inline style: { height: '95%' }
};
export default MyEvents;
return (
<>
{!initialFocus && (
<TicketsSdk testID="TicketsSdk" style={style || { flex: 1 }} />

Check warning on line 33 in src/TicketsSdkEmbeddedIos.tsx

GitHub Actions / lint

Inline style: { flex: 1 }
)}
</>
);