[Lens] fix showing points on line by default (elastic#197828)

## Summary Fix the missing style to show points in line charts. Line charts should show data points whenever the distance between points is larger than 40px.
tiansivive · Oct 29, 2024 · f5aa3e2 · f5aa3e2
1 parent f36177f
commit f5aa3e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/plugins/chart_expressions/expression_xy/public/components/xy_chart.test.tsx b/src/plugins/chart_expressions/expression_xy/public/components/xy_chart.test.tsx
@@ -842,7 +842,7 @@ describe('XYChart component', () => {
       const lineArea = dataLayers.find(LineSeries).at(0);
       const expectedSeriesStyle = expect.objectContaining({
         point: expect.objectContaining({
-          visible: showPoints ? 'always' : 'never',
+          visible: showPoints ? 'always' : 'auto',
         }),
       });
       expect(lineArea.prop('areaSeriesStyle')).toEqual(expectedSeriesStyle);

diff --git a/src/plugins/chart_expressions/expression_xy/public/helpers/data_layers.tsx b/src/plugins/chart_expressions/expression_xy/public/helpers/data_layers.tsx
@@ -298,7 +298,7 @@ export const getSeriesName: GetSeriesNameFn = (
 
 const getPointConfig: GetPointConfigFn = ({ markSizeAccessor, showPoints, pointsRadius }) => {
   return {
-    visible: showPoints || markSizeAccessor ? 'always' : 'never',
+    visible: showPoints || markSizeAccessor ? 'always' : 'auto',
     radius: pointsRadius,
     fill: markSizeAccessor ? ColorVariant.Series : undefined,
   };