Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UefiPkg/PiSmmCpuDxeSmm: Set SmmProfile Variable only for SMM Mode. #6555

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

yanxinzh
Copy link
Contributor

For PiSmmCpuDxeSmm driver. There is SetVariable logic for SmmProfile data. In traditional SMM Mode, still set the SmmProfile variable. But for standalone remove the SetVariable logic.

Description

<Include a description of the change and why this change was made.>

<For each item, place an "x" in between [ and ] if true. Example: [x] (you can also check items in GitHub UI)>

<Create the PR as a Draft PR if it is only created to run CI checks.>

<Delete lines in <> tags before creating the PR.>

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c Outdated Show resolved Hide resolved
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c Outdated Show resolved Hide resolved
@yanxinzh yanxinzh requested a review from niruiyu December 18, 2024 06:09
@jiaxinwu jiaxinwu self-requested a review December 18, 2024 06:14
Copy link
Member

@jiaxinwu jiaxinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also update the commit message:

UefiPkg/PiSmmCpuDxeSmm: Set SmmProfile Variable only for DXE SMM

Some platforms plan to move the Standalone MM CPU driver into the FSP.
However, there is no variable service support in FSP. Therefore, the
SetVariable logic for the Standalone MM CPU will be removed. With this
change, users can dump the SmmProfile data from the Memory Allocation
HOB: gMmProfileDataHobGuid.

This change does not impact the DXE SMM, which will still retrieve the
SmmProfile data from the variable service.

Signed-off-by: yanxinzh [email protected]

UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c Outdated Show resolved Hide resolved
@yanxinzh yanxinzh force-pushed the smmprofile branch 6 times, most recently from d22d89d to e6e32ec Compare December 19, 2024 03:27
@yanxinzh yanxinzh requested review from niruiyu and jiaxinwu December 19, 2024 05:16
@yanxinzh yanxinzh force-pushed the smmprofile branch 4 times, most recently from f3e3c2b to dedf187 Compare December 19, 2024 09:12
@yanxinzh yanxinzh force-pushed the smmprofile branch 2 times, most recently from facfba4 to 101d16e Compare December 19, 2024 10:03
Some platforms plan to move the Standalone MM CPU driver into the FSP.
However, there is no variable service support in FSP. Therefore, the
SetVariable logic for the Standalone MM CPU will be removed. With this
change, users can dump the SmmProfile data from the Memory Allocation
HOB: gMmProfileDataHobGuid.
This change does not impact the DXE SMM, which will still retrieve the
SmmProfile data from the variable service.

Signed-off-by: Yanxin Zhao <[email protected]>
@niruiyu niruiyu added the push Auto push patch series in PR if all checks pass label Dec 20, 2024
@mergify mergify bot merged commit e8ce6c5 into tianocore:master Dec 20, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants