Creates C-State, P-State and CPC objects under processor for X64 arch #6484
+2,015
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
lgao4,
LiuZhiguang001,
mdkinney,
pierregondois and
samimujawar
pierregondois
requested changes
Dec 6, 2024
abdattar
force-pushed
the
CpuObjects
branch
3 times, most recently
from
a13b8af to
8e23166
Compare
|
Hi @pierregondois, |
pierregondois
requested changes
Dec 9, 2024
abdattar
commented
Dec 13, 2024
There was a problem hiding this comment.
Hi @pierregondois,
Thank you for your detailed review.
I've included my comments on the factorization and attached the sample output for your reference.
acpi-SSDT-76AEF000.txt
Thanks
AbduL
|
The change in MdePkg is good to me. |
abdattar
force-pushed
the
CpuObjects
branch
2 times, most recently
from
d3cd998 to
4dc2801
Compare
|
Hi @pierregondois, |
DynamicTablesPkg/Library/Acpi/Common/AcpiSsdtCpuTopologyLib/X64/X64SsdtCpuTopologyGenerator.c
Outdated
Show resolved
Hide resolved
DynamicTablesPkg/Library/Acpi/Common/AcpiSsdtCpuTopologyLib/X64/X64SsdtCpuTopologyGenerator.c
Show resolved
Hide resolved
DynamicTablesPkg/Library/Acpi/Common/AcpiSsdtCpuTopologyLib/X64/X64SsdtCpuTopologyGenerator.c
Outdated
Show resolved
Hide resolved
added 3 commits
January 9, 2025 12:14
Add _CSD version and number of entries definition. These were introduced in the ACPI 3.0 specification. Reference: ACPI 6.5 specification, section 8.4.1.2, Table 8.3: C-State Dependency Package Values. Signed-off-by: Abdul Lateef Attar <[email protected]>
This commit introduces a set of functions designed to facilitate the creation and management of C-State (_CST, _CSD) and P-State (_PCT, _PSS) ACPI objects. Detailed Summary: 1) AmlCreateCstNode(): This function is responsible for creating a _CST (C-State) node, which is essential for defining processor idle states. 2) AmlAddCstState(): This function adds a C-State package to an existing CST node, allowing for the specification of individual C-State entries. 3) AmlCreateCsdNode(): This function creates a _CSD (C-State Dependency) node, which is used to describe dependencies between different C-States. 4) AmlCreatePctNode(): This function generates a _PCT (Performance Control) node, complete with PCT packages, to manage performance state transitions. 5) AmlCreatePssNode(): This function creates a _PSS (Performance Supported States) node, which lists the supported performance states for a processor. Signed-off-by: Abdul Lateef Attar <[email protected]>
This update adds new configuration manager objects for C-State and P-State. The C-State objects manage processor idle states, while the P-State objects handle processor performance states. This enhancement improves power management and performance tuning within the DynamicTablesPkg. Changes include: - Added C-State and P-State namespace objects in ArchCommonNameSpaceObjects.h. - Updated ConfigurationManagerObjectParser.c to support the new objects. - Revised Readme.md to document these changes. Signed-off-by: Abdul Lateef Attar <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
DynamicTablesPkg/Library/Acpi/Common/AcpiSsdtCpuTopologyLib/X64/X64SsdtCpuTopologyGenerator.c
Fixed
Show fixed
Hide fixed
added 3 commits
January 9, 2025 15:59
This patch adds several ACPI objects to the X64 CPU SSDT table to enhance power and performance management. The new objects include: - _CST: Defines CPU idle states for power saving. - _CSD: Specifies dependencies between CPU idle states. - _PCT: Provides an interface for controlling CPU performance states. - _PSS: Lists supported CPU performance states. - _PPC: Indicates current CPU performance capabilities. These additions help improve power efficiency and thermal management in X64 systems. Signed-off-by: Abdul Lateef Attar <[email protected]>
Introduce _PSD and _CPC ACPI objects for X64 platforms. Signed-off-by: Abdul Lateef Attar <[email protected]>
Adds _STA device status bit definitions. Reference: ACPI 6.5 specification, section 6.3.7 Signed-off-by: Abdul Lateef Attar <[email protected]>
Implement the _STA method for the CPU object based on the value provided by the configuration manager. Signed-off-by: Abdul Lateef Attar <[email protected]>
|
Hi @pierregondois, Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates below ACPI objects for processor device for X64 arch
C-State: Creates _CST and _CSD objects.
P-State: Create _PCT, _PSS objects plus _PPC method
_PSD object for domain dependency
_CPC continue performance control object
Update AML library to generate _CST, _CSD, _PCT and _PSS node.
Generates _STA method based on configuration data.
How This Was Tested
Tested on AMD Platform
Integration Instructions
N/A