Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdePkg/IndustryStandard: add definitions for CXL CEDT #6393

Closed
wants to merge 1 commit into from

Conversation

Ax-WangYuQuan
Copy link

Description

This adds #defines and struct typedefs for the various structure types in the CXL3.1 CXL Early Discovery Table (CEDT).

How This Was Tested

Include this header file for platform CEDT creation.

@Ax-WangYuQuan
Copy link
Author

This is my first time to start a pull requesting, so any instances if I have deviated from the standard practices or fallen short of the expected norms, please do not hesitate to inform me.

@mdkinney
Copy link
Member

Since this is part of CXL 3.1 specification, why not use file name Cxl3.1 so all content that is introduced in that version of the specs are added to that one file. Were these definitions included in an earlier version of the CXL spec?

Also, the ChangeID tag in the commit message should be removed

@Ax-WangYuQuan
Copy link
Author

Since this is part of CXL 3.1 specification, why not use file name Cxl3.1 so all content that is introduced in that version of the specs are added to that one file. Were these definitions included in an earlier version of the CXL spec?

Also, the ChangeID tag in the commit message should be removed

Thanks

@Ax-WangYuQuan
Copy link
Author

Ax-WangYuQuan commented Oct 31, 2024

Since this is part of CXL 3.1 specification, why not use file name Cxl3.1 so all content that is introduced in that version of the specs are added to that one file. Were these definitions included in an earlier version of the CXL spec?

If some structures were introduced from CXL 2.0, CXL 3.0, CXL 3.1 respectively, should I put these into/add the corresponding file?

The previous files (Cxl11.h, Cxl20.h) mainly contain the register definitions in CXL spec, which is mentioned in their header descriptions, but the CEDT is one type of acpi tables rather than registers, maybe there need a single separate file to define it?

@Ax-WangYuQuan Ax-WangYuQuan force-pushed the cxl-dev branch 3 times, most recently from 348d6c4 to f0a05a0 Compare November 5, 2024 10:48
@Ax-WangYuQuan Ax-WangYuQuan changed the title MdePkg/IndustryStandard: add definitions for CXL3.1 CEDT MdePkg/IndustryStandard: add definitions for CXL CEDT Nov 5, 2024
@Ax-WangYuQuan Ax-WangYuQuan reopened this Nov 13, 2024
This adds #defines and struct typedefs for the various structure
types in the CXL Early Discovery Table (CEDT).

Signed-off-by: Yuquan Wang <[email protected]>
Change-Id: Ic5334d63c4d9786beae755bc5d080a0b9ad6f26f
Copy link

mergify bot commented Nov 13, 2024

⚠️ The sha of the head commit of this PR conflicts with #6434. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants