-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Serial Clockrate based on data parsed from host firmware #6215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stating the obvious caught by CI :)
"WARNING - Line 3 of commit message is too long (76 >= 76)"
d05a6e5
to
bcb953e
Compare
Before make this change, please make sure this document got update. Source Code should be change like below. |
@gguo11837463 have opened a PR to update the documentation here: Will update this PR to only use the ClockRate if header version >= 2. |
bcb953e
to
b6b5afe
Compare
b6b5afe
to
b2a3c40
Compare
Signed-off-by: Matt DeVillier <[email protected]>
b2a3c40
to
f60437b
Compare
Description
Set PcdSerialClockRate from SerialPortInfo in UefiPayloadEntry.
The initial approach was to add a ClockRate field to UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO data struct, but simplified to setting the PCD directly based on feedback from reviewers.
These changes enable the serial clock rate value, which is already passed in from the host firmware, to be used when configuring the serial port for debug output. AMD Zen platform devices require this in order to have functional serial output.
How This Was Tested
build/boot multiple AMD/Intel devices and verify serial output works for all.
Integration Instructions
N/A