Armpkg setway cache maintenance #6194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
leiflindholm,
lgao4,
LiuZhiguang001,
mdkinney and
samimujawar
leiflindholm
approved these changes
Sep 12, 2024
|
@mergify refresh |
✅ Pull request refreshed |
|
@mergify requeue |
☑️ This pull request is already queued |
|
@mergify rebase |
☑️ Nothing to do
|
mdkinney
added
push
|
@mergify refresh |
✅ Pull request refreshed |
|
@mergify requeue |
☑️ This pull request is already queued |
Cache maintenance on the D-cache hierarchy as a whole is not supported by the ARM architecture, so drop the routines from ArmLib that pretend to implement it. Signed-off-by: Ard Biesheuvel <[email protected]>
Cache maintenance operations by set/way are not broadcast, and operate on individual architected caches, making them suitable only for en/disabling cache levels, which is the job of secure firmware, to be carried out while the CPU in question is not taking part in the cache coherency protocol. Managing the clean/dirty state of a memory range can only be done using cache maintenance by virtual address. So drop the set/way handling from ArmLib for ARM and AARCH64, as there is no context where it can be used correctly from EDK2. Signed-off-by: Ard Biesheuvel <[email protected]>
ardbiesheuvel
force-pushed
the
armpkg-setway-cache-maintenance
branch
from
0894fa5 to
f80cc63
Compare
ardbiesheuvel
added
push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove set/way d-cache maintenance from the ArmLib API. This will break Beagle unless tianocore/edk2-platforms#194 is merged first.