UefiPayloadPkg: Make UPL build script arch agnostic #5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation makes assumptions about arch it will be built for. Need to make it more generic to add follow up support for RISCV. Right now it does not build for RV until relevant dsc file is available. Cc: Guo Dong <[email protected]> Cc: Sean Rhodes <[email protected]> Cc: James Lu <[email protected]> Reviewed-by: Gua Guo <[email protected]> Signed-off-by: Dhaval Sharma <[email protected]>
LeanSheng
reviewed
Feb 23, 2024
| @@ -22,7 +22,7 @@ | |||
| SUPPORTED_ARCHITECTURES = IA32|X64 | |||
There was a problem hiding this comment.
should it be changed to IA32|X64|RISCV64?
|
hi @gguo11837463 ! I'm building from within coreboot and there's an issue I'm having with coreboot's makefile is building but at some point it ends up with a folder named patching it back to |
|
The line should be the below No other dsc uses BUILD_ARCH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation makes assumptions about arch it will be built for. Need to make it more generic to add follow up support for RISCV. Right now it does not build for RV until relevant dsc file is available.
Cc: Guo Dong [email protected]
Cc: Sean Rhodes [email protected]
Cc: James Lu [email protected]
Reviewed-by: Gua Guo [email protected]