BaseTools: Blackbox header cleanup #10601
Conversation
Minor cleanup Signed-off-by: Dionna Glaze <[email protected]>
Minor cleanup using namespace std in a header is infectious and therefore not best practice. The declaration build preprocessor may be disabled, which causes these error commands to cause build errors. Signed-off-by: Dionna Glaze <[email protected]>
tianocore-assign-reviewers
bot
requested review from
bexcran,
BobCF,
lgao4 and
YuweiChen1110
| @@ -77,7 +77,7 @@ class DllExportPCCTS ParserBlackBox { | |||
| { | |||
| if (f == NULL) | |||
| { | |||
| cerr << "invalid file pointer\n"; | |||
| std::cerr << "invalid file pointer\n"; | |||
There was a problem hiding this comment.
Should the PCCTS_NAMESPACE_STD on line 38 be dropped as well then?
There was a problem hiding this comment.
Pccts is from third party project. The general rule is to only do the necessary changes for it. Seemly, these changes are for code clean up, not for functionality. So, I don't suggest to merge them.
There was a problem hiding this comment.
Pccts is a code graveyard that I would recommend replacing with a first party implementation that uses modern language tools if you're not willing to take clean-up changes.
Trying to integrate software analysis with the codebase leads to alarms on code like this.
There was a problem hiding this comment.
@deeglaze Since the project to migrate all BaseTools C tools to Python has been abandoned, I want to take a look at modernizing all the code including replacing pccts.
This header is not included in any c program, and its use should not be dependent on whether the build is using namespace std. Signed-off-by: Dionna Glaze <[email protected]>
Description
Some code quality cleanups.
How This Was Tested
Builds