UefiPayloadPkg: Align base address for ACPI region #10566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AjanZhong
force-pushed
the
edk2-upstream
branch
2 times, most recently
from
59da910 to
2946b98
Compare
In platform which support ACPI 2.0 only, the base address of ACPI region is not page aligned. This unalinged base address leads to failure at BuildMemoryAllocationHob when parsing ACPI node in FdtParserLib, before building gUniversalPayloadAcpiTableGuid GUID HOB. Align base address of ACPI region down to EFI_PAGE_SIZE to make sure base address always aligned. Signed-off-by: Ajan Zhong <[email protected]>
AjanZhong
force-pushed
the
edk2-upstream
branch
from
2946b98 to
219d220
Compare
tianocore-assign-reviewers
bot
requested review from
benjamindoron,
gdong1,
gguo11837463,
jameslu8,
LinusvPelt and
Sean-StarLabs
LinusvPelt
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In platform which support ACPI 2.0 only, the base address of ACPI region is not page aligned. This unalinged base address leads to failure at BuildMemoryAllocationHob when parsing ACPI node in FdtParserLib, before building gUniversalPayloadAcpiTableGuid GUID HOB.
Align base address of ACPI region down to EFI_PAGE_SIZE to make sure base address always aligned.
FYI. These is log snippet read from Bare Metal hardware platform which supports ACPI 2.0:
efi: SMBIOS 3.0=0xf7e90000 ACPI 2.0=0xf472f018
How This Was Tested
<Describe the test(s) that were run to verify the changes.>
Validated at both QEMU and Bare Metal platform which support ACPI 2.0 only.
<Describe how these changes should be integrated. Use N/A if nothing is required.>