Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redfish/HiiUtilityLib Fix incorrect type assignment #10563

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

igorkulchytskyy
Copy link
Contributor

Replaced direct assignment of 'Value = (EFI_HII_VALUE *)&Question->Value' with the correct usage of HiiStatementValueToHiiValue function. This resolves the issue where EFI_HII_VALUE and HII_STATEMENT_VALUE types are incompatible, ensuring proper handling of Question->Value.

Replaced direct assignment of 'Value = (EFI_HII_VALUE *)&Question->Value'
with the correct usage of HiiStatementValueToHiiValue function.
This resolves the issue where EFI_HII_VALUE and HII_STATEMENT_VALUE types
are incompatible, ensuring proper handling of Question->Value.

Signed-off-by: Igor Kulchytskyy <[email protected]>
Copy link
Contributor

@nicklela nicklela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue.

@nicklela nicklela requested a review from changab December 24, 2024 07:04
@igorkulchytskyy igorkulchytskyy marked this pull request as ready for review December 24, 2024 15:39
@nicklela nicklela added the push Auto push patch series in PR if all checks pass label Dec 27, 2024
@mergify mergify bot merged commit 0986082 into tianocore:master Dec 27, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants