base_parser.py: support conditions checking for empty string #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apop5
force-pushed
the
personal/apop5/parserchange
branch
from
b07aa86 to
a5d662f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
==========================================
- Coverage 81.43% 81.43% -0.01%
==========================================
Files 56 45 -11
Lines 7514 7492 -22
==========================================
- Hits 6119 6101 -18
+ Misses 1395 1391 -4 ☔ View full report in Codecov by Sentry. |
Javagedes
force-pushed
the
personal/apop5/parserchange
branch
from
56abc95 to
d9d389b
Compare
Javagedes
changed the title
Javagedes
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base_parser.py did not support conditional directives that were comparing to empty strings (e.g.
!if $(MY_VAL) == "",!if $(MY_VAL) != "". The logic in_TokenizeConditional, was settingmodeto QUOTE_MODE twice because the token length was zero for an empty quote (len(token) == 0`).This PR Updates the logic to not enter QUOTE_MODE when its already in QUOTE_MODE, and to fall over to end of QUOTE_MODE.