gitignore_parser.py: Handle non-subpaths in rule file check #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #644 +/- ##
==========================================
- Coverage 81.43% 81.31% -0.13%
==========================================
Files 56 45 -11
Lines 7514 7491 -23
==========================================
- Hits 6119 6091 -28
- Misses 1395 1400 +5 ☔ View full report in Codecov by Sentry. |
Javagedes
reviewed
Sep 30, 2024
In IgnoreRule.match(), simply return False if the given absolute path is not a subpath of the base path instead of not handling the exception and breaking the overall build. Signed-off-by: Michael Kubacki <[email protected]>
Javagedes
force-pushed
the
git_ignore_parser_handle_diverging_paths
branch
from
190ad48 to
53346c2
Compare
Javagedes
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IgnoreRule.match(), simply return False if the given absolute path is not a subpath of the base path instead of not handling the exception and breaking the overall build.