Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inf_generator: Add [Install.NT.Services] section #462

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

Javagedes
Copy link
Contributor

Adds the [_Install.NT.Services] section with the default value of AddService=,2 to be compliant, and pass, the infverif.exe tool.

closes #451

@Javagedes Javagedes added the enhancement New feature or request label Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cadd3f2) 81.19% compared to head (63ff0f9) 81.20%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   81.19%   81.20%   +0.01%     
==========================================
  Files          57       57              
  Lines        7358     7363       +5     
==========================================
+ Hits         5974     5979       +5     
  Misses       1384     1384              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Adds the [<tag>_Install.NT.Services] section with the default value
of `AddService=,2` to be compliant, and pass, the infverif.exe tool.
@Javagedes Javagedes force-pushed the inf_generator-Services branch from c2a72bb to b4d8e95 Compare December 6, 2023 16:56
Copy link

@jorticus-msft jorticus-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this fixes validation in our build system

@Javagedes Javagedes merged commit e4677e1 into tianocore:master Dec 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Capsules are failing infverif validation
3 participants