table parsers: Use closest package path relative path #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the INF path provided in the FDF (INF <path>) to be relative to the closest package path, rather than the path provided. This is to prevent bugs in queries where we are comparing the INF path set by the generic INF parser (which uses the closest relative package path) to the INF path provided in the INF.
Javagedes
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
==========================================
+ Coverage 81.19% 81.20% +0.01%
==========================================
Files 57 57
Lines 7358 7362 +4
==========================================
+ Hits 5974 5978 +4
Misses 1384 1384 ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
Dec 6, 2023
makubacki
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF paths in the DSC and FDF can be defined as an absolute path, relative to the workspace, or relative to any package path. To ensure consistency with paths, this change converts any provided path to be relative to the closest package path. This simplifies queries that typically use the
pathcolumn for filtering, orjoincommands.That is to say, if there are two package paths:
Common/,Common/Special/, a path can be relative to either of these packages paths. So bothSpecial/Files/MyFile.candFiles/MyFile.care acceptable. However when inserting into the database, we now ensure that the closest package path relative path is used. In the above example, that meansFiles/MyFile.c.