base_parser: Update StripComment to consider quote groupings #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apop5
approved these changes
Nov 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #456 +/- ##
==========================================
- Coverage 81.14% 78.06% -3.08%
==========================================
Files 57 57
Lines 7340 7358 +18
==========================================
- Hits 5956 5744 -212
- Misses 1384 1614 +230 ☔ View full report in Codecov by Sentry. |
Previous update to StripComment would ignore any pound signs that were surrounded by quotes, but did not consider if the sign was inside two quotes or between two sets of two quotes (i.e. `" # "` vs `" 1 " # " 2 "`). This commit updates StripComment to check this scenario and not strip if the pound sign is inside two quotes.
Javagedes
force-pushed
the
more-line-support
branch
from
6bb5c42 to
61a9e88
Compare
makubacki
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous update to StripComment would ignore any pound signs that were surrounded by quotes, but did not consider if the sign was inside two quotes or between two sets of two quotes (i.e.
" # "vs" 1 " # " 2 "). This commit updates StripComment to check this scenario and not strip if the pound sign is inside two quotes.This additionally adds support for ignoring escaped quotes.