base_parser: Don't treat pound signs wrapped in quotes as comments #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edk2 supports pound signs in pcd definitions, however the simple edk2 config file parser provided by edk2-pytool-library did not support this. This commit updates the removal of comments to only remove pound signs (and everything after) if the pound sign is not wrapped in quotes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #452 +/- ##
=======================================
Coverage 81.13% 81.14%
=======================================
Files 57 57
Lines 7338 7340 +2
=======================================
+ Hits 5954 5956 +2
Misses 1384 1384 ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
Nov 18, 2023
makubacki
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edk2 supports pound signs in pcd definitions, however the simple edk2 config file parser provided by edk2-pytool-library did not support this. This commit updates the removal of comments to only remove pound signs (and everything after) if the pound sign is not wrapped in quotes.