-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edk2toollib/database: Switch to sqlite3 #406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javagedes
force-pushed
the
switch-sqlite3
branch
2 times, most recently
from
September 6, 2023 20:58
ac4dc57
to
940e4f7
Compare
Switch to using sqlite3 rather than TinyDB as this is a true database that supports SQL queries and other expected functionality that TinyDB does not.
Javagedes
force-pushed
the
switch-sqlite3
branch
from
September 6, 2023 22:54
940e4f7
to
931bb5b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #406 +/- ##
==========================================
- Coverage 81.06% 80.90% -0.16%
==========================================
Files 60 57 -3
Lines 7304 7276 -28
==========================================
- Hits 5921 5887 -34
- Misses 1383 1389 +6
☔ View full report in Codecov by Sentry. |
Javagedes
force-pushed
the
switch-sqlite3
branch
from
September 7, 2023 16:15
ec9bc53
to
a1a325b
Compare
Javagedes
commented
Sep 19, 2023
makubacki
reviewed
Sep 19, 2023
makubacki
approved these changes
Sep 19, 2023
Javagedes
commented
Sep 19, 2023
makubacki
reviewed
Sep 19, 2023
Co-authored-by: Michael Kubacki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using sqlite3 rather than TinyDB as this is a true database that supports SQL queries and other expected functionality that TinyDB does not.
Additionally: