Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edk2toollib/database: Switch to sqlite3 #406

Merged
merged 33 commits into from
Sep 19, 2023

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Sep 6, 2023

Switch to using sqlite3 rather than TinyDB as this is a true database that supports SQL queries and other expected functionality that TinyDB does not.

Additionally:

  • Removes all queries as they were just a bridge due to the fact that TinyDB did not support SQL queries and in particular, joins.
  • Adds a Package Table, which can contain generic information about the package (right now, only the containing repository)

@Javagedes Javagedes force-pushed the switch-sqlite3 branch 2 times, most recently from ac4dc57 to 940e4f7 Compare September 6, 2023 20:58
Switch to using sqlite3 rather than TinyDB as this is a true database
that supports SQL queries and other expected functionality that TinyDB
does not.
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 98.44% and project coverage change: -0.16% ⚠️

Comparison is base (17a2dac) 81.06% compared to head (4c7e841) 80.90%.

❗ Current head 4c7e841 differs from pull request most recent head c5211a5. Consider uploading reports for the commit c5211a5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   81.06%   80.90%   -0.16%     
==========================================
  Files          60       57       -3     
  Lines        7304     7276      -28     
==========================================
- Hits         5921     5887      -34     
- Misses       1383     1389       +6     
Files Changed Coverage Δ
edk2toollib/uefi/edk2/parsers/dsc_parser.py 87.27% <85.71%> (-0.39%) ⬇️
edk2toollib/database/tables/package_table.py 92.59% <92.59%> (ø)
edk2toollib/database/__init__.py 100.00% <100.00%> (ø)
edk2toollib/database/edk2_db.py 100.00% <100.00%> (ø)
edk2toollib/database/tables/__init__.py 100.00% <100.00%> (ø)
edk2toollib/database/tables/base_table.py 100.00% <100.00%> (ø)
edk2toollib/database/tables/environment_table.py 100.00% <100.00%> (ø)
edk2toollib/database/tables/inf_table.py 100.00% <100.00%> (ø)
edk2toollib/database/tables/instanced_fv_table.py 100.00% <100.00%> (ø)
edk2toollib/database/tables/instanced_inf_table.py 98.51% <100.00%> (+0.13%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Javagedes Javagedes marked this pull request as ready for review September 19, 2023 17:34
@Javagedes Javagedes changed the title Switch to sqlite3 edk2toollib/database: Switch to sqlite3 Sep 19, 2023
@Javagedes Javagedes merged commit 8b1ce2a into tianocore:master Sep 19, 2023
11 of 12 checks passed
@Javagedes Javagedes added this to the v0.18.0 milestone Sep 19, 2023
@Javagedes Javagedes added the enhancement New feature or request label Sep 19, 2023
@Javagedes Javagedes self-assigned this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants