Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci_build: Add fail-fast option #847

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

Javagedes
Copy link
Contributor

Adds a new command line argument, -f, --fail-fast to stuart_ci_build that will cause the script to exit immediately if any ci plugin fails.

stuart_ci_build -c .\.pytool\CISettings.py -p MdeModulePkg --disable-all NestedPackageCheck=run
image

stuart_ci_build -c .\.pytool\CISettings.py -p MdeModulePkg --disable-all NestedPackageCheck=run --fail-fast
image

Adds a new command line argument, `-f`, `--fail-fast` to stuart_ci_build
that will cause the script to exit immediately if any ci plugin fails.
@Javagedes Javagedes requested review from a user, makubacki and apop5 July 9, 2024 19:32
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.43%. Comparing base (bf643b0) to head (6acbf78).
Report is 80 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
- Coverage   78.75%   78.43%   -0.33%     
==========================================
  Files          49       40       -9     
  Lines        4909     4901       -8     
==========================================
- Hits         3866     3844      -22     
- Misses       1043     1057      +14     
Files Coverage Δ
edk2toolext/invocables/edk2_ci_build.py 49.32% <20.00%> (+0.81%) ⬆️

... and 48 files with indirect coverage changes

@Javagedes Javagedes merged commit 0587ad6 into tianocore:master Jul 9, 2024
23 of 25 checks passed
@Javagedes Javagedes added this to the 0.27.10 milestone Jul 9, 2024
@Javagedes Javagedes added the enhancement New feature or request label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants