Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust tool version reporting #678

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

makubacki
Copy link
Member

Adds support to report Rust tool versions in the version aggregator so the versions are available in the Build Tools Report.

Also prints the version to the logger at info level similar to other versions so it is part of the build output.


Example output in the build console:

INFO - cargo version: 1.73.0
INFO - cargo make version: 0.37.2
INFO - rustc version: 1.73.0

Example output in the HTML build report:
image

Adds support to report Rust tool versions in the version aggregator
so the versions are available in the Build Tools Report.

Also prints the version to the logger at info level similar to other
versions so it is part of the build output.

Signed-off-by: Michael Kubacki <[email protected]>
@Javagedes
Copy link
Contributor

Could you write a test that makes sure we parse cargo and rustc versions as expected? Just to ensure if the executables start reporting their versions differently, we catch the break here. We don't have a great way to do it with cargo make unless we go through installing it first, which is slow. It may or may not be worth it.

@makubacki
Copy link
Member Author

Could you write a test that makes sure we parse cargo and rustc versions as expected? Just to ensure if the executables start reporting their versions differently, we catch the break here. We don't have a great way to do it with cargo make unless we go through installing it first, which is slow. It may or may not be worth it.

Sure, I'll do that tomorrow. Thanks for quickly looking at the PR.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #678 (96e5584) into master (4f2b186) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   78.73%   78.83%   +0.10%     
==========================================
  Files          49       49              
  Lines        4820     4843      +23     
==========================================
+ Hits         3795     3818      +23     
  Misses       1025     1025              
Files Coverage Δ
edk2toolext/edk2_invocable.py 78.16% <100.00%> (+2.99%) ⬆️
edk2toolext/invocables/edk2_ci_build.py 48.48% <100.00%> (+0.39%) ⬆️
edk2toolext/invocables/edk2_platform_build.py 72.15% <100.00%> (+0.35%) ⬆️

@makubacki
Copy link
Member Author

Could you write a test that makes sure we parse cargo and rustc versions as expected?

Sure, I'll do that tomorrow. Thanks for quickly looking at the PR.

Done in the latest push.

@Javagedes Javagedes added the enhancement New feature or request label Oct 20, 2023
@Javagedes Javagedes added this to the 0.25.1 milestone Oct 20, 2023
@Javagedes Javagedes merged commit 8a0566e into tianocore:master Oct 20, 2023
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants