Silicon/Ampere: Set EFI_ACPI_6_3_LOW_POWER_S0_IDLE_CAPABLE in FADT #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the EFI_ACPI_6_3_LOW_POWER_S0_IDLE_CAPABLE flag in the FADT. The ACPI specification says the LOW_POWER_S0_IDLE_CAPABLE flag means that the platform is able to achieve power savings in S0 similar to or better than those typically in S3. It effectively means that the system will not achieve any power savings by transitioning to S3. Since Altra doesn't support the S3 state, set this flag. This resolves the FWTS S0idleNoFADT error. Signed-off-by: Rebecca Cran <[email protected]>
ghost
requested review from
chuongtranle
reviewed
Oct 1, 2024
nhivp
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the EFI_ACPI_6_3_LOW_POWER_S0_IDLE_CAPABLE flag in the FADT.
The ACPI specification says the LOW_POWER_S0_IDLE_CAPABLE flag means that the platform is able to achieve power savings in S0 similar to or better than those typically in S3. It effectively means that the system will not achieve any power savings by transitioning to S3. Since Altra doesn't support the S3 state, set this flag.
This resolves the FWTS S0idleNoFADT error.