Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampere I2C changes (expand set of buses listed in Ac01.h and bump SSIF speed to 400 kHz) #218

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

ghost
Copy link

@ghost ghost commented Sep 30, 2024

Boards based on the Altra SoC from vendors such as ADLINK are configured differently and require access to I2C buses not listed in Ac01.h. Fix this by expanding AC01_I2C_BASE_ADDRESS_LIST to contain the full set of buses available.

Since this changes the indexing of the buses, update the Mt Jade files to match. Add a new PCD to contain the bus number of the RTC since this is different between Mt Jade and ADLINK's COM-HPC-ALT platform.

Bump the I2C bus speed used for the IPMI SSIF link to the BMC from 100 to 400 kHz to match the requirement listed in Platform/Ampere/JadePkg/PlatformPortingGuide.md.

Rebecca Cran added 2 commits September 30, 2024 07:18
Boards based on the Altra SoC from vendors such as ADLINK are
configured differently and require access to I2C buses not
listed in Ac01.h. Fix this by expanding AC01_I2C_BASE_ADDRESS_LIST to
contain the full set of buses available.

Since this changes the indexing of the buses, update the Mt Jade files
to match. Add a new PCD to contain the bus number of the RTC since this
is different between Mt Jade and ADLINK's COM-HPC-ALT platform.

Signed-off-by: Rebecca Cran <[email protected]>
Bump the I2C bus speed used for the IPMI SSIF link to the BMC from
100 to 400 kHz to match the requirement listed in
Platform/Ampere/JadePkg/PlatformPortingGuide.md.

Signed-off-by: Rebecca Cran <[email protected]>
@ghost ghost force-pushed the ampere-i2c-buses branch from 680a226 to 97ffe02 Compare September 30, 2024 13:19
Copy link
Contributor

@chuongtranle chuongtranle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Chuong Tran [email protected]

@nhivp nhivp merged commit ab28b89 into tianocore:master Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants