Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManageabilityPkg: Add IpmiCommandLib PEI instance #213

Merged
merged 1 commit into from
Oct 1, 2024
Merged

ManageabilityPkg: Add IpmiCommandLib PEI instance #213

merged 1 commit into from
Oct 1, 2024

Conversation

nhivp
Copy link
Member

@nhivp nhivp commented Sep 27, 2024

This introduces IpmiCommandLib/IpmiCommandLibPei.inf for the support of the IPMI command library in PEI. It is consistent with the IpmiLib which has supported separately an instance in PEI.

Side-Note: Ampere Mt. Jade will use this library instance.

@nhivp nhivp requested a review from changab as a code owner September 27, 2024 04:32
abdattar
abdattar approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@abdattar abdattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@changab any comments ?

@nhivp
ManageabilityPkg: Add IpmiCommandLib PEI instance
d013fa6 
This introduces IpmiCommandLib/IpmiCommandLibPei.inf for the support of
the IPMI command library in PEI. It is consistent with the IpmiLib which
has supported separately an instance in PEI.

Signed-off-by: Nhi Pham <[email protected]>
@nhivp nhivp force-pushed the add-IpmiCommandLibPei branch from cf2c1ed to d013fa6 Compare September 30, 2024 12:12
changab
changab reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@changab changab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nhivp, no technical issues, just want to confirm with you that, supposedly we don't have the specific code for edk2 boot phases in IpmiCommandLib library. Thus we don't have to separate the implementation into different folders such as Dxe/Smm/Pei, right?

@nhivp
Copy link
Member Author

nhivp commented Sep 30, 2024

Hi @nhivp, no technical issues, just want to confirm with you that, supposedly we don't have the specific code for edk2 boot phases in IpmiCommandLib library. Thus we don't have to separate the implementation into different folders such as Dxe/Smm/Pei, right?

Hi @changab

Correct, the implementation remains consistent across phases. The extra INF for PEI simply ensures that the IPMI stack is buildable, as the IpmiLib has separate instances for PEI and DXE.

@changab changab merged commit 979d0f0 into tianocore:master Oct 1, 2024
1 check passed
@changab
Copy link
Member

changab commented Oct 1, 2024

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changab changab changab approved these changes

@abdattar abdattar Awaiting requested review from abdattar

Assignees

@nhivp nhivp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhivp @changab @abdattar