Build failure with Intel platforms on VS2019 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4854 Build issues are currently seen on Intel platforms due to PR 5957. This PR introduces the requirement for any instance of SecCore to include StackCheckLibNull, which is not currently included on Intel platform builds. The fix is to add this library to SecCore. Signed-off-by: Nate DeSimone <[email protected]>
nate-desimone
requested review from
ChaselChiu,
SaiChaganty,
jackpot51,
benjamindoron and
mdkinney
as code owners
ChaselChiu
approved these changes
Sep 23, 2024
SaiChaganty
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4854
Build issues are currently seen on Intel platforms due to PR tianocore/edk2#5957. This PR introduces the requirement for any instance of SecCore to include StackCheckLibNull, which is not currently included on Intel platform builds.
The fix is to add this library to SecCore.