Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of PcdStandaloneMmEnable has broken build of BoardPkg(s) #207

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

nate-desimone
Copy link
Member

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4853

When the PcdStandaloneMmEnable FeaturePcd was added, it was not added to MinPlatformFeaturesPcd.dsc.inc

Because of this, any existing BoardPkg that does not have Standalone MM support will no longer build because the default value of FALSE is not declared during DSC parsing.

The fix is to add the PCD to MinPlatformFeaturesPcd.dsc.inc

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4853

When the PcdStandaloneMmEnable FeaturePcd was added, it was not added
to MinPlatformFeaturesPcd.dsc.inc

Because of this, any existing BoardPkg that does not have Standalone MM
support will no longer build because the default value of FALSE is not
declared during DSC parsing.

The fix is to add the PCD to MinPlatformFeaturesPcd.dsc.inc

Signed-off-by: Nate DeSimone <[email protected]>
@nate-desimone nate-desimone merged commit f9cd719 into tianocore:master Sep 23, 2024
1 check passed
@nate-desimone nate-desimone deleted the fix_pcdstandalonemm branch September 23, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants