SbsaQemu: update to SMBIOS 3.7

We were saying "SMBIOS 3.4" but structure sizes were from 3.7 one so FWTS complained: FAILED [HIGH] DMIBadTableLength: Test 3, Type 17 expects length of 0x5c, has incorrect length of 0x64 Added all missing fields as well. Signed-off-by: Marcin Juszkiewicz <[email protected]>
tianocore · Oct 9, 2024 · 60e800b · 60e800b
1 parent f3044bf
commit 60e800b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -518,7 +518,7 @@ DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
   #
   # SMBIOS entry point version
   #
-  gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0304
+  gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0307
   gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0
 
   gArmTokenSpaceGuid.PcdSystemBiosRelease|0x0100

diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuSmbiosDxe/SbsaQemuSmbiosDxe.c b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuSmbiosDxe/SbsaQemuSmbiosDxe.c
@@ -112,17 +112,21 @@ SMBIOS_TABLE_TYPE17  mMemDevInfoType17 = {
       0  // Reserved                        :10;
     }
   },
-  0,                        // FirwareVersion
-  0,                        // ModuleManufacturerID (unknown)
-  0,                        // ModuleProductID (unknown)
-  0,                        // MemorySubsystemControllerManufacturerID (unknown)
-  0,                        // MemorySubsystemControllerProductID (unknown)
-  0,                        // NonVolatileSize
-  0,                        // VolatileSize; initialized at runtime, refer to MemDevInfoUpdateSmbiosType17
-  0,                        // CacheSize
-  0,                        // LogicalSize (since MemoryType is not MemoryTypeLogicalNonVolatileDevice)
-  0,                        // ExtendedSpeed
-  0                         // ExtendedConfiguredMemorySpeed
+  0, // FirwareVersion
+  0, // ModuleManufacturerID (unknown)
+  0, // ModuleProductID (unknown)
+  0, // MemorySubsystemControllerManufacturerID (unknown)
+  0, // MemorySubsystemControllerProductID (unknown)
+  0, // NonVolatileSize
+  0, // VolatileSize; initialized at runtime, refer to MemDevInfoUpdateSmbiosType17
+  0, // CacheSize
+  0, // LogicalSize (since MemoryType is not MemoryTypeLogicalNonVolatileDevice)
+  0, // ExtendedSpeed
+  0, // ExtendedConfiguredMemorySpeed
+  0, // Pmic0ManufacturerID
+  0, // Pmic0RevisionNumber
+  0, // RcdManufacturerID
+  0, // RcdRevisionNumber
 };
 CHAR8                *mMemDevInfoType17Strings[] = {
   NULL