Build SoftFloat with MSVC #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes these errors: ``` LibSoftfloat.lib(netf2.obj) : error LNK2001: unresolved external symbol _softfloat_float128_eq LibSoftfloat.lib(lttf2.obj) : error LNK2001: unresolved external symbol _softfloat_float128_lt LibSoftfloat.lib(letf2.obj) : error LNK2001: unresolved external symbol _softfloat_float128_le ``` Signed-off-by: Sergey Sudnitsyn [[email protected]](mailto:[email protected])
|
Not sure about this - another option is to avoid including softfloat-for-gcc.h completely like it is done in e.g. fpgetmask.c: Or just wrap the whole softfloat-for-gcc.h in ifdef SOFTFLOAT_FOR_GCC / endif |
|
The expected Signed-off-by format would be: Signed-off-by: Sergey Sudnitsyn [email protected] |
I thought I've put it exactly like this? |
mdkinney
approved these changes
Oct 2, 2024
|
Here are the details on the commit message format: https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these errors:
Signed-off-by: Sergey Sudnitsyn [email protected]