Add filter configurations at a per-Source granularity #248
Conversation
There was a problem hiding this comment.
The changes for adding partial clones to submodules looks good as do the changes to define the partial clone strategy at a per level in the manifest file. Can we separate them into two separate commits?
Your commit message indicates that this is also addressing #247 the two partial clone methods are not really intended to be combined as such I would prefer to address this by making them mutually exclusive arguments, erroring out and letting the user make the correct choice.
ndhaller
force-pushed
the
treeless_blobless
branch
from
03b37d6 to
627c31f
Compare
Added a separate commit for the submodule change. |
project_utils/submodule.py
Outdated
| @@ -148,6 +156,33 @@ def _get_submodule_enable(manifest, remote_name, combo): | |||
| return source.enable_submodule | |||
| return False | |||
|
|
|||
| def _get_blobless_enable(manifest, remote_name, combo): | |||
There was a problem hiding this comment.
These two methods will only take into account repositories which have manifest level filtering set and will not catch cases of users inputing a filter type on the clone cmd line. This could lead to a mismatch in clone types for the parent repo and the submodule containing them.
In the case where the parent repository is not already present on the system we must also check command line parameters. (Note: in some situations, no selective initialization, the initialization is performed in the _update() method)
In the case where the repository is already present we should defer to the git config file for that repository. Specifically the command git config remote.origin.partialclonefilter will return the partial clone type if any that was used to create the repository.
ndhaller
force-pushed
the
treeless_blobless
branch
from
a5d09be to
935a41d
Compare
Adds treeless="true" and blobless="true" as attributes to a Combination Source. Add arg --full to disable repo attributes. --treeless, --blobless, and --full args will disable the per-Source attributes. Allow up to one of --treeless, --blobless and --full args to be used per edkrepo clone. Related issues: tianocore#239 add filter configurations at a per-Source or per-Remote granularity tianocore#247 clone with both --treeless and --blobless encounter git error Signed-off-by: Nathaniel Haller <[email protected]>
Filter options applied to a repo during the edkrepo clone command will apply to submodules when edkrepo updates submodules. Signed-off-by: Nathaniel Haller <[email protected]>
ndhaller
force-pushed
the
treeless_blobless
branch
from
935a41d to
c536d54
Compare
Adds treeless="true" and blobless="true" as attributes to a Combination Source.
During edkrepo clone and checkout, if enableSubmodule="true" on the Combination Source, the filter setting applies to the submodules as well.
--treeless and treeless="true" have priority over --blobless and blobless="true" if multiple are used.
During edkrepo clone, --treeless and --blobless do not apply to the submodule filter settings.
Related issues:
#239
add filter configurations at a per-Source or per-Remote granularity
#247
clone with both --treeless and --blobless encounter git error