Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filter configurations at a per-Source or per-Remote granularity #239

Open
ndhaller opened this issue Apr 23, 2024 · 0 comments
Open

Comments

@ndhaller
Copy link
Contributor

edkrepo 3.2.0 release adds the --treeless and --blobless options to the edkrepo clone command.

This applies the git clone --filter=tree:0 and --filter=blob:none across all Source in a Combination.

I would like the option to specify 'blobless' and 'treeless' in the manifest file at the Source level or the Remote level.

Example:
--filter=blob:none on the Edk2Repo and Edk2PlatformsRepo, and --filter=tree:0 on the Edk2NonOsiRepo and FspRepo when cloning the Intel-MinPlatform project.

https://github.com/tianocore/edk2-edkrepo-manifest/blob/main/edk2-platforms/Intel-MinPlatform/IntelMinPlatformManifest.xml

    <Remote name="Edk2Repo">https://github.com/tianocore/edk2.git</Remote>
    <Remote name="Edk2PlatformsRepo">https://github.com/tianocore/edk2-platforms.git</Remote>
    <Remote name="Edk2NonOsiRepo">https://github.com/tianocore/edk2-non-osi.git</Remote>
    <Remote name="FspRepo">https://github.com/intel/FSP.git</Remote>
    <Combination name="master" description="the master branch from edk2 Repo, master branch from edk2-platforms repo, master branch from edk2-non-osi repo, master branch from FSP repo">
      <Source localRoot="edk2" remote="Edk2Repo" branch="master" sparseCheckout="true" enableSubmodule="true" />
      <Source localRoot="edk2-platforms" remote="Edk2PlatformsRepo" branch="master" sparseCheckout="true" />
      <Source localRoot="edk2-non-osi" remote="Edk2NonOsiRepo" branch="master" sparseCheckout="true" />
      <Source localRoot="FSP" remote="FspRepo" branch="master" sparseCheckout="false" />
    </Combination>
ndhaller added a commit to ndhaller/edk2-edkrepo that referenced this issue May 9, 2024
Adds treeless="true" and blobless="true" as attributes to a Combination Source.
During edkrepo clone and checkout, if enableSubmodule="true" on the Combination Source,
the filter setting applies to the submodules as well.

--treeless and treeless="true" have priority over --blobless and blobless="true" if multiple are used.

During edkrepo clone, --treeless and --blobless do not apply to the submodule filter settings.

Related issues:

tianocore#239
add filter configurations at a per-Source or per-Remote granularity

tianocore#247
clone with both --treeless and --blobless encounter git error

Signed-off-by: Nathaniel Haller <[email protected]>
ndhaller added a commit to ndhaller/edk2-edkrepo that referenced this issue May 16, 2024
Adds treeless="true" and blobless="true" as attributes to a Combination Source.
Add arg --full to disable repo attributes.

--treeless, --blobless, and --full args will disable the per-Source attributes.
Allow up to one of --treeless, --blobless and --full args to be used per edkrepo clone.

Related issues:

tianocore#239
add filter configurations at a per-Source or per-Remote granularity

tianocore#247
clone with both --treeless and --blobless encounter git error

Signed-off-by: Nathaniel Haller <[email protected]>
ndhaller added a commit to ndhaller/edk2-edkrepo that referenced this issue Jun 18, 2024
Adds treeless="true" and blobless="true" as attributes to a Combination Source.
Add arg --full to disable repo attributes.

--treeless, --blobless, and --full args will disable the per-Source attributes.
Allow up to one of --treeless, --blobless and --full args to be used per edkrepo clone.

Related issues:

tianocore#239
add filter configurations at a per-Source or per-Remote granularity

tianocore#247
clone with both --treeless and --blobless encounter git error

Signed-off-by: Nathaniel Haller <[email protected]>
ndhaller added a commit to ndhaller/edk2-edkrepo that referenced this issue Jun 28, 2024
Adds treeless="true" and blobless="true" as attributes to a Combination Source.
Add arg --full to disable repo attributes.

--treeless, --blobless, and --full args will disable the per-Source attributes.
Allow up to one of --treeless, --blobless and --full args to be used per edkrepo clone.

Related issues:

tianocore#239
add filter configurations at a per-Source or per-Remote granularity

tianocore#247
clone with both --treeless and --blobless encounter git error

Signed-off-by: Nathaniel Haller <[email protected]>
ashedesimone pushed a commit that referenced this issue Jun 28, 2024
Adds treeless="true" and blobless="true" as attributes to a Combination Source.
Add arg --full to disable repo attributes.

--treeless, --blobless, and --full args will disable the per-Source attributes.
Allow up to one of --treeless, --blobless and --full args to be used per edkrepo clone.

Related issues:

#239
add filter configurations at a per-Source or per-Remote granularity

#247
clone with both --treeless and --blobless encounter git error

Signed-off-by: Nathaniel Haller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant