Skip to content

Commit

Permalink
Revert "BaseTools: Fix DSC LibraryClass precedence rule"
Browse files Browse the repository at this point in the history
This reverts commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 for tag202208.
This brings the behavior changes, and needs more discussion.

Signed-off-by: Liming Gao <[email protected]>
Acked-by: Ard Biesheuvel <[email protected]>
Acked-by: Bob Feng <[email protected]>
  • Loading branch information
lgao4 authored and BobCF committed Sep 7, 2022
1 parent 594b795 commit 2a50cdf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions edk2basetools/Workspace/DscBuildData.py
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,7 @@ def LibraryClasses(self):
if ModuleType != TAB_COMMON and ModuleType not in SUP_MODULE_LIST:
EdkLogger.error('build', OPTION_UNKNOWN, "Unknown module type [%s]" % ModuleType,
File=self.MetaFile, ExtraData=LibraryInstance, Line=LineNo)
LibraryClassDict[ModuleType, Arch, LibraryClass] = LibraryInstance
LibraryClassDict[Arch, ModuleType, LibraryClass] = LibraryInstance
if LibraryInstance not in self._LibraryInstances:
self._LibraryInstances.append(LibraryInstance)

Expand All @@ -881,7 +881,7 @@ def LibraryClasses(self):
for LibraryClass in LibraryClassSet:
# try all possible module types
for ModuleType in SUP_MODULE_LIST:
LibraryInstance = LibraryClassDict[ModuleType, self._Arch, LibraryClass]
LibraryInstance = LibraryClassDict[self._Arch, ModuleType, LibraryClass]
if LibraryInstance is None:
continue
self._LibraryClasses[LibraryClass, ModuleType] = LibraryInstance
Expand Down

0 comments on commit 2a50cdf

Please sign in to comment.