Merge pull request #11 from tiagosiebler/#10/sign

fix(#10): signature error for param-less non-GET requests
tiagosiebler · May 5, 2021 · daf8cb0 · daf8cb0
2 parents 4ec5aa3 + 09dcacc
commit daf8cb0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ftx-api",
-  "version": "1.0.6",
+  "version": "1.0.7",
   "description": "Node.js connector for FTX's REST APIs and WebSockets",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

diff --git a/src/util/requestWrapper.ts b/src/util/requestWrapper.ts
@@ -174,11 +174,11 @@ export default class RequestUtil {
     };
   }
 
-  getRequestSignature(
+  private getRequestSignature(
     method: Method,
     endpoint: string,
-    secret: string | undefined,
-    params: string | object = ''
+    secret?: string | undefined,
+    params?: string | object
   ): { timestamp: number; sign: string; } {
     const timestamp = Date.now() + (this.timeOffset || 0);
     if (!secret) {
@@ -188,7 +188,10 @@ export default class RequestUtil {
       };
     }
 
-    const paramsPayload = method == 'GET' ? params : JSON.stringify(params);
+    const paramsPayload = method === 'GET'
+      ? params
+      : params ? JSON.stringify(params) : '';
+
     const signature_payload = `${timestamp}${method}/api/${endpoint}${paramsPayload}`;
     return {
       timestamp,