Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: New BPMN Editor add new icons and improve morphing panels #133

Open
wants to merge 12 commits into
base: new-bpmn-editor
Choose a base branch
from

Conversation

kbowers-ibm
Copy link

@kbowers-ibm kbowers-ibm commented Oct 31, 2024

This PR adds new icons to the gateway and task nodes. And beautifies the morphing panels for all node types.
taskMorphingPanel
startEvent
intermediateEvent
intermediateThrowEvent
stopEvent
gatewayIcons
taskIconsandMarkers
Properties panel examples:
Screenshot 2024-11-07 115841
Screenshot 2024-11-07 115830
Screenshot 2024-11-07 115820
Screenshot 2024-11-07 115806

@kbowers-ibm kbowers-ibm force-pushed the gateway-task-morphing-improvements branch from d7ba0ed to dfecbe2 Compare November 27, 2024 12:49
@jomarko
Copy link

jomarko commented Dec 2, 2024

Is there a way we can help with this? Do some manual review using some live online version of new icons? Or do you have a vsix that we could install locally ?

@kbowers-ibm
Copy link
Author

Hi @jomarko,
Thanks for your interest! Tiago showed me how to create an online version, so if you'd like to check it out that'd be great! :)
https://kbowers-ibm.github.io/?path=/story/dev-web-app--web-app

Copy link

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbowers-ibm hi, the icons are nice. Congrats on this PR.

I share some findings, probably some of them not related to this PR, but better to mention them I think, so you can decide if and how to handle them.

01

For the task morphing, there is duplicated number 5. See the attached screenshot.
Screenshot 2024-12-05 121115

02

Subprocess morphing seems to work only using mouse and click. Pressing numbers on the keyboard seems to not work. Used chrome on windows.

03

Shape of the 'Timer' and 'Cancel' event in the morph panel is slightly different from icon in the actual node. Do not have strong opinion about it as I am not UX designer. I understand that smaller morph icons do not always allow to use exactly the same shape as node.
Screenshot 2024-12-05 125629
Screenshot 2024-12-05 125528

@kbowers-ibm
Copy link
Author

Hi @jomarko
Thanks for the feedback - appreciate you taking the time!
#1 I think Tiago did that intentionally to easily toggle between a standard task and reusable task, but I agree it's definitely a deviation! Maybe we can follow the behaviour of events where the standard event is 1 and have a standard Task be 1 and a resuable task be something else.
#2 Good point! I didn't touch SubProcesses as part of this PR, but it's probably a good idea to add them in here as opposed to a separate PR.
#3 Good catch! The timer event was intentional as having the 12 ticks was a bit too messy in the smaller morphing panel, but the X could probably be done a bit better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants