-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: New BPMN Editor add new icons and improve morphing panels #133
base: new-bpmn-editor
Are you sure you want to change the base?
NO-ISSUE: New BPMN Editor add new icons and improve morphing panels #133
Conversation
7924ca0
to
87e227d
Compare
* NO-ISSUE: Adding new SVGs to the new BPMN Editor * fixing fill changes
d7ba0ed
to
dfecbe2
Compare
Is there a way we can help with this? Do some manual review using some live online version of new icons? Or do you have a vsix that we could install locally ? |
Hi @jomarko, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbowers-ibm hi, the icons are nice. Congrats on this PR.
I share some findings, probably some of them not related to this PR, but better to mention them I think, so you can decide if and how to handle them.
01
For the task morphing, there is duplicated number 5. See the attached screenshot.
02
Subprocess morphing seems to work only using mouse and click. Pressing numbers on the keyboard seems to not work. Used chrome on windows.
03
Shape of the 'Timer' and 'Cancel' event in the morph panel is slightly different from icon in the actual node. Do not have strong opinion about it as I am not UX designer. I understand that smaller morph icons do not always allow to use exactly the same shape as node.
Hi @jomarko |
This PR adds new icons to the gateway and task nodes. And beautifies the morphing panels for all node types.
Properties panel examples: