Update macOS bash on CI (#129)

* Update macOs bash on CI Signed-off-by: Ricardo Zanini <[email protected]> * Fix bash at 5; fix macOS wording Signed-off-by: Ricardo Zanini <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]>
tiagobento · Sep 27, 2024 · 343be84 · 343be84
1 parent c0e2aa5
commit 343be84
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/.github/actions/setup-env/action.yml b/.github/actions/setup-env/action.yml
@@ -246,6 +246,15 @@ runs:
           libxml2-utils > /dev/null 2>&1
         fi
 
+    - name: "Update bash for macOS (macOS Only)"
+      shell: bash
+      if: runner.os == 'macOS'
+      run: |
+        echo "STEP: Update bash for macOS (macOS Only)"
+        brew update
+        brew install bash@5
+        echo "/usr/local/bin" >> $GITHUB_PATH
+
     - name: "Print storage usage (after setup)"
       shell: bash
       run: |

diff --git a/README.md b/README.md
@@ -54,6 +54,7 @@ To build and test all packages of the Apache KIE Tools project, you're going to
 - Helm `3.13.3` _(To install, follow these instructions: https://helm.sh/docs/intro/install/)_
 - Make
 - xmllint _(To install, follow these instructions: https://www.baeldung.com/linux/xmllint)_
+- bash `5.x` _(On Linux or Nix you should be fine. On macOS, follow these instructions to use zsh: https://support.apple.com/102360)_
 
 > **ℹ️ NOTE**
 >

diff --git a/...n/resources/modules/kogito-jobs-service-common/added/launch/kogito-jobs-service-common.sh b/...n/resources/modules/kogito-jobs-service-common/added/launch/kogito-jobs-service-common.sh
@@ -31,7 +31,7 @@ function configure() {
 }
 
 function configure_jobs_service_events() {
-    if [ "$(echo "${ENABLE_EVENTS}" | tr '[:lower:]' '[:upper:]')" == "TRUE" ]; then
+    if [ "${ENABLE_EVENTS^^}" == "TRUE" ]; then
         KOGITO_JOBS_PROPS="${KOGITO_JOBS_PROPS} -Dquarkus.profile=events-support"
     fi
 }