Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prettier): add .prettierrc file #23

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

with-heart
Copy link
Contributor

This change adds a .prettierrc file to the project.

From looking at the existing code and #8, the current style seems to match prettier defaults except for trailingComma which is set to "all". By specifying only that override, prettier will respect its default values for all other rules.

This allows plugin:prettier/recommended to know what to recommend, and prevents anyone with a global .prettierrc in their local env (like me 😁) from constantly overwriting the expected style.

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2021

CLA assistant check
All committers have signed the CLA.

@nihaals
Copy link
Member

nihaals commented Mar 2, 2021

I haven't yet looked at prettier's config much as I've been working on actually writing components but this should be a great first change as we decide on style later on. Right now everything's been done just with VSCode's prettier and all default config (afaik).

@nihaals nihaals merged commit 8684570 into thunderstore-io:master Mar 2, 2021
@nihaals
Copy link
Member

nihaals commented Mar 2, 2021

Thanks!

@with-heart
Copy link
Contributor Author

Yeap, just noticed that this should actually be all defaults and trailingComma shouldn't have a custom value. Will fix to just stick with the defaults in a bit :)

@with-heart with-heart deleted the add-prettierrc branch March 2, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants