add TODO

thundergolfer · Jan 11, 2024 · 2fcab83 · 2fcab83
1 parent 1f0cd9e
commit 2fcab83
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/books/computer_systems_app/labs/shell/tsh.c b/books/computer_systems_app/labs/shell/tsh.c
@@ -206,6 +206,7 @@ void eval(char *cmdline)
         exit(0); // TODO: dont always exit 0
     } else {
         debug("after fork: parent waiting for child");
+        // TODO: should this be set using setpgid(0, 0) in child instead?
         if (setpgid(pid, pid)) { // give unique proc group ID
             unix_error("failed to set proc group ID");
         }