Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically populate Lemmy domains in Android manifest #834

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 17, 2023

Pull Request Description

This PR goes along with #832 and adds support for updating the Android manifest file with Lemmy domains automatically.

@micahmo micahmo marked this pull request as draft October 17, 2023 04:28
@micahmo micahmo mentioned this pull request Oct 17, 2023
8 tasks
@ggichure
Copy link
Collaborator

Is it possible to order the instances alphabetically?

@micahmo
Copy link
Member Author

micahmo commented Oct 19, 2023

Is it possible to order the instances alphabetically?

Yes they should be alphabetical after this workflow runs! See instances.dart.

@micahmo
Copy link
Member Author

micahmo commented Oct 19, 2023

This should be good to go now that #832 is done!

@micahmo micahmo marked this pull request as ready for review October 19, 2023 19:08
Copy link
Collaborator

@ggichure ggichure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit b7ed7c0 into thunder-app:develop Oct 20, 2023
@micahmo micahmo deleted the feature/populate-android-manifest-domains branch October 21, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants