Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app-link support for thunderapp.dev #1644

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Add app-link support for thunderapp.dev #1644

merged 4 commits into from
Dec 19, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR adds support for Android's app links - specifically, for https://thunderapp.dev. Note that this will only work for the release builds (GitHub and Google Play) since their release key SHA-256 fingerprints have been added to assetlinks.json.

@gwbischof If you would like to test this locally, you'll have to provide me the SHA-256 fingerprints from your debug signing keys. See https://developer.android.com/training/app-links/verify-android-applinks#web-assoc on how to obtain the fingerprints.

Once you provide this to me, I can temporarily add the fingerprints to assetlinks.json to enable app links for your debug builds!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hjiangsu
Copy link
Member Author

I've updated this to also include support for iOS universal links!

This is equivalent to the app links on Android. The one difference here is that you'll have to navigate to https://thunderapp.dev/oauth/ in Safari to see the option to navigate back to Thunder.

@gwbischof If you want to test deep linking using iOS, you'll likely have to provide me the team ID so that I can add that into the apple-app-site-associations file on https://thunderapp.dev. Otherwise, only release builds will be associated with the universal links. To find this information, see https://developer.apple.com/help/account/manage-your-team/locate-your-team-id/

@hjiangsu
Copy link
Member Author

One more update, this PR also includes support for universal links on macOS!

Note that these implementations just allow us to open up Thunder from https://thunderapp.dev - there was no implementation change to handle the deep links (so this will likely result in "This type of link is not supported at the moment" message.)

@hjiangsu hjiangsu merged commit 1a43f0b into develop Dec 19, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/app-links branch December 19, 2024 02:15
@hjiangsu
Copy link
Member Author

@micahmo I've merged this into develop, but let me know if you notice any issues with the commits after you previously approved it!

handleSharedFilesAndText();
}

if (!kIsWeb && (Platform.isAndroid || Platform.isIOS || Platform.isMacOS)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we want to handleNotifications for MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants